From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@muc.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Hugh Dickens <hugh@veritas.com>,
Michael Ellerman <michael@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 1/6] Generic implemenatation of BUG.
Date: Tue, 03 Oct 2006 08:53:06 -0700 [thread overview]
Message-ID: <45228762.7000005@goop.org> (raw)
In-Reply-To: <20061003103740.GB73786@muc.de>
Andi Kleen wrote:
>> Because powerpc also records the function name, I added this to i386 and
>> x86-64 for consistency. Strictly speaking the function name is redundant with
>> kallsyms, so perhaps it can be dropped from powerpc.
>>
>
> It would be good to change it to use kallsyms() then.
>
It does, in effect, when it prints the oops message and backtrace.
>>
>> #ifdef CONFIG_BUG
>> +
>> +#ifdef CONFIG_GENERIC_BUG
>> +struct bug_entry {
>> + unsigned long bug_addr;
>> +#ifdef CONFIG_DEBUG_BUGVERBOSE
>> + const char *file;
>> + unsigned short line;
>> +#endif
>> + unsigned short flags;
>>
>
> Can't you put the flags into the high bits of the line? I don't think
> we have any 64kLOC files.
I thought about it, but it would still be padded out to 12 bytes on
i386, and more on 64-bit platforms. And it doesn't matter that much.
J
prev parent reply other threads:[~2006-10-03 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061003010842.438670755@goop.org>
[not found] ` <20061003010933.392428107@goop.org>
2006-10-03 4:23 ` [PATCH 5/6] From: Andrew Morton <akpm@osdl.org> Paul Mackerras
2006-10-03 4:33 ` Andrew Morton
2006-10-03 5:19 ` Paul Mackerras
2006-10-03 5:50 ` Andrew Morton
2006-10-03 6:55 ` Paul Mackerras
2006-10-03 7:20 ` Andrew Morton
2006-10-03 7:25 ` Benjamin Herrenschmidt
[not found] ` <20061003010930.971200285@goop.org>
2006-10-03 10:37 ` [PATCH 1/6] Generic implemenatation of BUG Andi Kleen
2006-10-03 15:53 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45228762.7000005@goop.org \
--to=jeremy@goop.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.