All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve French <smfltc@us.ibm.com>
To: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: linux-fsdevel@vger.kernel.org,
	Shirish S Pargaonkar <shirishp@us.ibm.com>
Subject: Re: What trigge fsync of file on last close of the open inode?
Date: Tue, 03 Oct 2006 15:45:49 -0500	[thread overview]
Message-ID: <4522CBFD.3010202@us.ibm.com> (raw)
In-Reply-To: <1159905941.18918.7.camel@kleikamp.austin.ibm.com>

Dave Kleikamp wrote:
>> Someone had reported a problem with a writepages call coming in on with 
>> no open files (so presumably the file was closed, with dirty pages not 
>> written).
>>     
>
> This is normal behavior for most file systems.  I thought cifs protected
> this by flushing dirty data in cifs_close.  I don't think any data
> should be dirtied after cifs_close is called (on the last open file
> handle).
>   
I found it ...

cifs exports flush, filp_close calls flush (before calling close)

cifs_flush calls filemap_fdatawrite

May be a case in which filemap_fdatawrite returns before the write(s) is 
sent to the vfs and write races with close (although cifs will defer a 
file close if a write is pending on that handle)?

  reply	other threads:[~2006-10-03 20:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-03 19:53 What trigge fsync of file on last close of the open inode? Steve French
2006-10-03 20:05 ` Dave Kleikamp
2006-10-03 20:45   ` Steve French [this message]
2006-10-03 21:15     ` Zach Brown
2006-10-03 21:40       ` Dave Kleikamp
2006-10-03 23:43         ` Zach Brown
2006-10-04 15:13       ` Steve French
2006-10-03 23:13     ` Jeremy Allison
2006-10-04 20:46       ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4522CBFD.3010202@us.ibm.com \
    --to=smfltc@us.ibm.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=shaggy@austin.ibm.com \
    --cc=shirishp@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.