From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D701C61DCB for ; Thu, 27 Aug 2026 10:36:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wzXSq-00041w-OY; Thu, 27 Aug 2026 06:36:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzXSe-0003z1-7z for qemu-riscv@nongnu.org; Thu, 27 Aug 2026 06:35:57 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzXSb-0006KK-C2 for qemu-riscv@nongnu.org; Thu, 27 Aug 2026 06:35:55 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67R9GlJn470803 for ; Thu, 27 Aug 2026 10:35:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= g1yHx4Ee814g0XA3qlGc9mEeDnlyfhtuhU0XBGeoJsU=; b=ei6nR69EQ1fcCksI 3xe2uaqFUjWJfooD+vNW+YXmWGqC3N/zVFG66JFsMTv8IP1KooIOBQrb9yMxAYju g1G/1bSxmqWsOnHdRbzFXjSaWDqyr77hbeehptdM5ckkXyyyOTn/VDm6BjF5UQLx G3HuhkiwDRp0aW3z4Y4KXha2Iv72FPK5tTsRl3aS+nEyAO3PmdyrKUW/ujJd5Ko6 B/4/nEbyFtTFcxLyC3cPFaTCxLKyiSebZOmgf5sfF/H17g/kJ8plbQ3n0A57SzDf PuSiiZSRl1739HDk3n0MoiCoq8+YwRAtFTUHZz+FjZxbSrguqAOCin4EXh7b3AYm q6qYhA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ga8m5jate-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Aug 2026 10:35:49 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51a8db414c7so26085791cf.0 for ; Thu, 27 Aug 2026 03:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787826948; x=1788431748; darn=nongnu.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=g1yHx4Ee814g0XA3qlGc9mEeDnlyfhtuhU0XBGeoJsU=; b=WZNHChNnwq7UYKrvoA1uyiY2Wkl1Yfd87JW+/O0PlPUJFDFUUtTEcuRkEGpbrk3JZ6 NW0+aBfsx0lUKnPdGiFR8LvfDxpTr45WtN4cqF+bWfFM3gdgB6G/lpEr/V6Bqsptl1FO e9i3L5i2gnuFMwmwWd6+sWyLIZW+TS8JohZY6vAgj+Zh4HqNO244kUtRqvmSYVG7cf08 eP84egsKxOJdtt4NHevLjbSgUima+R67tiAI15lZ1qyK9HMJrCmyBzGVCgrrbCcAJ7Zy D0W4YBKCU8ZDb20iLv9zZpMoRfiWUuMgmo/qzuJ6GjDL/YyNTWxt81sNd9S9Y26FZix4 JFEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787826948; x=1788431748; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g1yHx4Ee814g0XA3qlGc9mEeDnlyfhtuhU0XBGeoJsU=; b=SfbBlQLMXX8Q71C7ORbcyQAguvBNDLOPFU67V4m7PJXrpBT7cGU35qgH8vWRD1bV7g tpuw6BQlt/k0hS5PlslKKzg+mGV83XTP+CVGqKkMfYWbpLLhOberL+jfqyjUUiQcAPA0 FugXctXTl9CkSbY1TC/ESFQsC5ElkfOPdHSwlL02C/pLbCWBmSbaLeadXcoSfcJSPJ+Q j+YnFCaYZo0MuENfq2TkNN2uLf4aFJf+HqpDrSwE2hX0jX3hOtJwLUQ+bXbjz8FZ6f0u lXES7KJ/iqoq4TPP/uxln9OTKuK7276FCfYiLXT2Cv22QK1tJzzNmZX1ZPcGCR+sciER bhjw== X-Forwarded-Encrypted: i=1; AHgh+RofHxB/weIaaT4hWuWne3cDy3EN9CHfyJEN5WUe3k3YB364DUhGtFkGXhBygqJZOH+2QNij66zB4s2F@nongnu.org X-Gm-Message-State: AFuF++m4z2jEZLPifRlByow82aZyJdXZUjbMd3v8OBnDFO3kUtruiBT5 kMK59eK/HTvOC/MGaMq7BQnK/vX6ofavU+0IDOx6vV0TGhqWT5OHHshYCVYRTPO137vLGa+GxLy HrrkTuwimHhyDQCpFlrmBjkQ+o5l5ler1KYxw509SDbnrMlEeL/teOXd7Tg== X-Gm-Gg: AR+sD13q4k9ryFJAc8NQrbcw3gzQQVdk4jghB1qPB3SOKMzXpZadKxc8AZS5V3XB95c g/N9wsark8YK7w0R0aambAPiXMLJ+ZBJH0Lz2/nb+e+evO7C86FscRoNW/aBqSlNJ6gm4Ug5n8Y Uu6j9gWABIvys5u8TjFPxfGPAefYfCOS1W77NaWM+NTZT+48cvq34Z7fWExBGgqzoXM7jnDjUiP lQeijoekjk3zxsOhHuQPSKeYcnntMDjRaGMjcbC5KDE1OLkDXPDgz7I3p8aRHmscpsFMs8blj5X FllbU1n9fQO46Yna6ECniD8k1eqDbWgnfOXRu0JgleCCALqM97ugOwszt4yNSkCxCi4GCKjYvQa 1WL8QSj1g8QnZnhfOmfZnygX+om/6Z1DHtg== X-Received: by 2002:a05:622a:3ce:b0:527:7a5b:ca67 with SMTP id d75a77b69052e-52e423deda8mr129226511cf.20.1787826947914; Thu, 27 Aug 2026 03:35:47 -0700 (PDT) X-Received: by 2002:a05:622a:3ce:b0:527:7a5b:ca67 with SMTP id d75a77b69052e-52e423deda8mr129225391cf.20.1787826947123; Thu, 27 Aug 2026 03:35:47 -0700 (PDT) Received: from [192.168.69.226] (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b4d08d86dsm40967145e9.12.2026.08.27.03.35.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2026 03:35:46 -0700 (PDT) Message-ID: <4522b97d-5399-4bd6-867c-eade341afb9c@oss.qualcomm.com> Date: Thu, 27 Aug 2026 12:35:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Rename ssi_transfer to ssi_transfer8 Content-Language: en-US To: Peter Maydell , stephensportia@gmail.com Cc: qemu-devel@nongnu.org, Palmer Dabbelt , Jamin Lin , qemu-ppc@nongnu.org, =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Steven Lee , Andrew Jeffery , Harsh Prateek Bora , Subbaraya Sundeep , Troy Lee , "Edgar E. Iglesias" , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis , Strahinja Jankovic , qemu-arm@nongnu.org, Tyrone Ting , Nicholas Piggin , Aditya Gupta , Kane Chen , Francisco Iglesias , Joel Stanley , Hao Wu , Glenn Miles , qemu-riscv@nongnu.org, Jean-Christophe Dubois , Portia Stephens References: <20260825040452.1322251-1-stephensportia@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 12Xq4kMJx7CY31tRdiQjjxdCMZxfZnGh X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDA4NyBTYWx0ZWRfX4gdYTbC1m9zN jYhay/mlfevxu0l5kpGThVzS5a4t3D31bAv78uXA6w6SBRCnoGlYuRnNvQgxh+gkUnbAtO4OPCo 3gP0UoPO9LxUSJJn3BiPZ964yYDssYo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDA4NyBTYWx0ZWRfX8eE+lKcXY8hp ZZ50hFPcauH/OIguB4QNGtXouaCP0zpqHER2IThRDPXe8hxa6PdWlTKA1XrXy667NGqcKlnj4aV 1svG+pQXjEH11td5hUFsbB7khBSM18soxIJELkR52xLWibYGHvpxxJYLIX0YQFsSMI9LXhESw2w MTkVwI1DPjIHYwVF0EJxjGnONTkQckEerHLZ16ntPYaHY6ffgOmq1Fsz+nrkvWDAbYd20t8IXeE hJoOTVFnDCDkgsKxDqvYRWT76PkWNWiH+xRLQtKhf9gajWs0/uHcSpRizf/svCIrUyoc+IwGIBW A+w1qaq5IQxYaUf0HA6RleMi52huna5bo7ZpVT2+TgW6QNmJfcwm4kGZmpt3DrBLEFmCCwMhynk a7SN5xz9wFBFcSDCjkjA3cvoO5/O6EpPYCNfchLi67U8GSXvy5u/LeAPxAHTrJn4NCJKsz/bw5A olDZ+5BaG/m8u3ebN1Q== X-Proofpoint-GUID: 12Xq4kMJx7CY31tRdiQjjxdCMZxfZnGh X-Authority-Analysis: v=2.4 cv=SomgLvO0 c=1 sm=1 tr=0 ts=6a901305 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=pGLkceISAAAA:8 a=t9496tuAAAAA:8 a=jNFeHvk_SeYrjZSZ0a8A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=4wQ91nGE5lQcD7eh5OX0:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_04,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270087 Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 27/8/26 11:19, Peter Maydell wrote: > On Tue, 25 Aug 2026 at 05:05, wrote: >> >> From: Portia Stephens >> >> The ssi_transfer function comments say that it takes a word varying >> between 8-bits and 32-bits. ssi_transfer takes a 32-bit arg to transfer >> but there is no means to indicate the number of bits that should >> actually be transferred. All child classes of SSI_PERIPHERAL class have >> transfer functions that, despite accepting a 32-bit tx, only transfer a >> single byte; m25p80_transfer8(), ssi_sd_transfer(), ssd0323_transfer(). >> >> The current implementation depends on the SSI model to know >> what peripheral model will be attached and what transfer size it >> expects which is error prone. If a SSI_PERIPHERAL model was written that >> accepted 32-bit transfers, it could not attach to any existing SSI >> models. > > What is the motivation for this change? > > As far as I know for the hardware SSI protocol, it is indeed > the case that the SSI controller (and/or the guest software) needs > to know what transfer size the attached device expects: the > controller just transmits (or expects to receive) however many > bits it is programmed for. > >> This change updates the the naming of ssi_transfer to ssi_transfer8, as >> well as changes the return value and transmit argument to be 8-bit. > > This means that the API will no longer work for a controller > and device that aren't 8-bit. Yes exactly. Clearer than the mail I just wrote, thanks hehe. > We happen not to have any of those > devices today, but why specifically stop them working? I guess remembering having see forks with 16-bit devices, but that was few years ago (I know forks don't have they voice here, but just to mention the current API is working for them).