All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <esandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: different defaults in mke2fs.conf vs. the code itself?
Date: Wed, 04 Oct 2006 12:37:02 -0500	[thread overview]
Message-ID: <4523F13E.5090309@redhat.com> (raw)

from mke2fs.conf in 1.39:

[defaults]
        base_features = sparse_super,filetype,resize_inode,dir_index
        blocksize = 4096

and yet (for example) in PRS():

        if (blocksize <= 0) {
                profile_get_integer(profile, "defaults", "blocksize", 0,
                                    1024, &use_bsize);
                profile_get_integer(profile, "fs_types", fs_type,
                                    "blocksize", use_bsize, &use_bsiz

So the code itself defaults to 1k blocks, but the shipped config file
defaults to 4k blocks?  We noticed this when mke2fs.conf went missing
from the install environment, and formatting large filesystems took a
-very- long time.

Shouldn't these match?  Or for that matter, why should the shipped
config file be either overriding or re-stating defaults in the code
itself?  Seems a bit strange to me.

-Eric

                 reply	other threads:[~2006-10-04 17:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4523F13E.5090309@redhat.com \
    --to=esandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.