From: Jeff Garzik <jeff@garzik.org>
To: Frederik Deweerdt <deweerdt@free.fr>
Cc: linux-kernel@vger.kernel.org, arjan@infradead.org,
matthew@wil.cx, alan@lxorguk.ukuu.org.uk, akpm@osdl.org,
rdunlap@xenotime.net, gregkh@suse.de
Subject: Re: [RFC PATCH] add pci_{request,free}_irq take #3
Date: Wed, 04 Oct 2006 15:50:04 -0400 [thread overview]
Message-ID: <4524106C.8010807@garzik.org> (raw)
In-Reply-To: <20061004193229.GA352@slug>
Frederik Deweerdt wrote:
> --- 2.6.18-mm3.orig/include/linux/interrupt.h
> +++ 2.6.18-mm3/include/linux/interrupt.h
> @@ -75,6 +75,13 @@ struct irqaction {
> struct proc_dir_entry *dir;
> };
>
> +#ifndef ARCH_VALIDATE_IRQ
> +static inline int is_irq_valid(unsigned int irq)
> +{
> + return irq ? 1 : 0;
> +}
> +#endif /* ARCH_VALIDATE_IRQ */
I ACK everything except the above snippet. I just don't think it's
linux/interrupt.h material, sorry.
If a consensus of arch maintainers (i.e. not just willy) think it's
fine, then I'm overruled, otherwise...
Jeff
next prev parent reply other threads:[~2006-10-04 19:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 19:32 [RFC PATCH] add pci_{request,free}_irq take #3 Frederik Deweerdt
2006-10-04 19:43 ` [RFC PATCH] move aic7xxx to pci_request_irq Frederik Deweerdt
2006-10-04 19:44 ` [RFC PATCH] move aic79xx " Frederik Deweerdt
2006-10-04 19:46 ` [RFC PATCH] move tg3 " Frederik Deweerdt
2006-10-04 19:46 ` [RFC PATCH] move e1000 " Frederik Deweerdt
2006-10-04 19:50 ` Jeff Garzik [this message]
2006-10-04 20:29 ` [RFC PATCH] add pci_{request,free}_irq take #3 Frederik Deweerdt
2006-10-04 20:33 ` Matthew Wilcox
2006-10-04 21:26 ` Frederik Deweerdt
2006-10-05 13:59 ` Alexey Dobriyan
2006-10-05 14:36 ` Frederik Deweerdt
2006-10-06 10:04 ` Alexey Dobriyan
2006-10-06 10:31 ` Frederik Deweerdt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4524106C.8010807@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=deweerdt@free.fr \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.