From: Gerd Hoffmann <kraxel@suse.de>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [patch] Fix 32bit xen-tools build.
Date: Thu, 05 Oct 2006 11:22:12 +0200 [thread overview]
Message-ID: <4524CEC4.1080309@suse.de> (raw)
In-Reply-To: <C14A8705.2197%Keir.Fraser@cl.cam.ac.uk>
Keir Fraser wrote:
> The mbootpack change seems wrong. It's not installed on the target machine
> (it's a build-system tool) so it should actually be built with HOSTCFLAGS,
> not CFLAGS. Is that reasonable?
For the x86_32 on x86_64 it works as-is, because the 32bit binaries work
on 64bit too. Looking at it strictly it is indeed not fully correct
though, HOSTCCFLAGS should be used instead. But some more tweaks are
needed then, you'll have to take care that the object files are compiled
with HOSTCC (and HOSTCFLAGS) too (they are not at the moment).
> Presumably the most important part of this patch is the change to LDFLAGS
> and ASFLAGS?
Yes, that makes most bits compile fine, except qemu-dm.
> I suppose any halfway modern version of binutils must support
> those flags (otherwise gcc -m32 wouldn't work)?
Yes, gcc passes -m32 through to the linker.
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
http://www.suse.de/~kraxel/julika-dora.jpeg
next prev parent reply other threads:[~2006-10-05 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 8:48 [patch] Fix 32bit xen-tools build kraxel
2006-10-05 8:55 ` Keir Fraser
2006-10-05 9:22 ` Gerd Hoffmann [this message]
2006-10-05 10:40 ` Gerd Hoffmann
2006-10-05 11:45 ` John Levon
-- strict thread matches above, loose matches on Subject: below --
2006-10-20 8:36 kraxel
2006-10-20 12:25 ` John Levon
2006-10-21 7:43 ` Keir Fraser
2006-10-23 7:35 ` Gerd Hoffmann
2006-10-23 8:51 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4524CEC4.1080309@suse.de \
--to=kraxel@suse.de \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.