All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: make-bogus-warnings-go-away tree [was: 2.6.18-mm3]
Date: Thu, 05 Oct 2006 06:05:16 -0400	[thread overview]
Message-ID: <4524D8DC.1080100@garzik.org> (raw)
In-Reply-To: <20061005083754.GA1060@elte.hu>

Ingo Molnar wrote:
> A small suggestion: to give GCC folks a chance to actually fix this, 
> could we actively annotate these places instead of working them around?


There was a patch posted in the past, mentioned in the thread discussed 
my #gccbug branch, that permitted annotations with zero code size 
changes.  I think that sort of annotation approach would be preferred. 
It was something like

#define noinit_warning(x) \
	do { (void) (x) = (x); } while (0)

but given my memory, that's probably all wrong.

So, I agree that annotations are a good idea, but I'm not so sure that 
your proposed "= 0" approach is the best one.  Remember, we need to do 
this for multi-member structures, integers, and pointers, not just 
things easily assigned to zero.

	Jeff



  reply	other threads:[~2006-10-05 10:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-03  7:11 2.6.18-mm3 Andrew Morton
2006-10-03 14:33 ` 2.6.18-mm3 Michal Piotrowski
2006-10-03 17:37 ` 2.6.18-mm3 Badari Pulavarty
2006-10-03 18:01   ` 2.6.18-mm3 Andrew Morton
2006-10-03 18:01     ` 2.6.18-mm3 Andrew Morton
2006-10-03 18:16     ` 2.6.18-mm3 Badari Pulavarty
2006-10-03 18:16       ` 2.6.18-mm3 Badari Pulavarty
2006-10-03 18:05   ` 2.6.18-mm3 Badari Pulavarty
2006-10-03 18:05     ` 2.6.18-mm3 Badari Pulavarty
2006-10-04 13:44 ` [-mm PATCH] fixed PCMCIA au1000_generic.c Yoichi Yuasa
2006-10-06  6:18   ` Om Narasimhan
2006-10-06  7:31     ` Yoichi Yuasa
2006-10-07 22:31       ` Om Narasimhan
2006-10-04 15:14 ` 2.6.18-mm3 oops in xfrm_register_mode Steve Fox
2006-10-04 16:57   ` Andrew Morton
2006-10-04 21:02     ` Steve Fox
2006-10-05 15:06       ` Badari Pulavarty
2006-10-05  8:37 ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Ingo Molnar
2006-10-05 10:05   ` Jeff Garzik [this message]
2006-10-05 16:21     ` make-bogus-warnings-go-away tree Roland Dreier
2006-10-05 20:52     ` make-bogus-warnings-go-away tree [was: 2.6.18-mm3] Kyle Moffett
2006-10-05 16:37   ` Adrian Bunk
2006-10-05 16:44     ` Jeff Garzik
2006-10-05 16:51       ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4524D8DC.1080100@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.