From: Jeff Garzik <jeff@garzik.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Val Henson <val_henson@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
netdev@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
Date: Fri, 06 Oct 2006 15:16:36 -0400 [thread overview]
Message-ID: <4526AB94.7060200@garzik.org> (raw)
In-Reply-To: <1160161519800-git-send-email-matthew@wil.cx>
Matthew Wilcox wrote:
> Since some devices may not implement the MWI bit, we should check that
> the write did set it and return an error if it didn't.
>
> Signed-off-by: Matthew Wilcox <matthew@wil.cx>
ACK, though (as it seems you are doing) you should audit pci_set_mwi()
users to make sure behavior matches up with this implementation
Jeff
next prev parent reply other threads:[~2006-10-06 19:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 19:05 [PATCH 1/2] [PCI] Check that MWI bit really did get set Matthew Wilcox
2006-10-06 19:05 ` [PATCH 2/2] [TULIP] Check the return value from pci_set_mwi() Matthew Wilcox
2006-10-06 19:15 ` Jeff Garzik
2006-10-06 19:28 ` Matthew Wilcox
2006-10-06 19:59 ` Jeff Garzik
2006-10-07 5:34 ` Grant Grundler
2006-10-07 14:44 ` Jeff Garzik
2006-10-06 19:16 ` Jeff Garzik [this message]
2006-10-14 4:41 ` [PATCH 1/2] [PCI] Check that MWI bit really did get set Andrew Morton
2006-10-14 5:21 ` Greg KH
2006-10-14 14:02 ` Matthew Wilcox
2006-10-14 20:48 ` Andrew Morton
2006-10-15 3:20 ` Matthew Wilcox
2006-10-15 6:53 ` Andrew Morton
2006-10-15 13:54 ` Matthew Wilcox
2006-10-15 17:47 ` Andrew Morton
2006-10-15 7:08 ` [Bulk] " David Brownell
2006-10-15 7:08 ` David Brownell
2006-10-15 13:52 ` Matthew Wilcox
2006-10-15 14:21 ` Alan Cox
2006-10-15 13:57 ` Matthew Wilcox
2006-10-15 17:45 ` Andrew Morton
2006-10-15 19:16 ` David Brownell
2006-10-15 19:34 ` Andrew Morton
2006-10-15 22:45 ` David Brownell
2006-10-15 23:18 ` Andrew Morton
2006-10-16 0:02 ` Alan Cox
2006-10-15 23:44 ` Andrew Morton
2006-10-16 0:44 ` Paul Mackerras
2006-10-16 1:10 ` Andrew Morton
2006-10-16 2:07 ` David Brownell
2006-10-16 10:58 ` Alan Cox
2006-10-16 11:02 ` Alan Cox
2006-10-16 0:16 ` David Brownell
2006-10-16 0:31 ` Andrew Morton
2006-10-16 10:59 ` Alan Cox
2006-10-15 21:52 ` [Bulk] " Alan Cox
2006-10-16 0:00 ` Paul Mackerras
2006-10-16 0:15 ` Andrew Morton
2006-10-16 0:21 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4526AB94.7060200@garzik.org \
--to=jeff@garzik.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=netdev@vger.kernel.org \
--cc=val_henson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.