Syed Amer Gilani wrote:
> I wanted to test rtcan but the mscan Driver fails to compile:
> 
>  CC      drivers/xenomai/can/mscan/rtcan_mscan.o
> drivers/xenomai/can/mscan/rtcan_mscan.c:85: error: syntax error before
> string constant
> drivers/xenomai/can/mscan/rtcan_mscan.c:85: warning: type defaults to
> 'int' in declaration of 'MODULE_PARM'
> drivers/xenomai/can/mscan/rtcan_mscan.c:85: warning: function
> declaration isn't a prototype
> drivers/xenomai/can/mscan/rtcan_mscan.c:85: warning: data definition
> has no type or storage class
> drivers/xenomai/can/mscan/rtcan_mscan.c:89: error: syntax error before
> string constant
> drivers/xenomai/can/mscan/rtcan_mscan.c:89: warning: type defaults to
> 'int' in declaration of 'MODULE_PARM'
> drivers/xenomai/can/mscan/rtcan_mscan.c:89: warning: function
> declaration isn't a prototype
> drivers/xenomai/can/mscan/rtcan_mscan.c:89: warning: data definition
> has no type or storage class
> make[4]: *** [drivers/xenomai/can/mscan/rtcan_mscan.o] Fehler 1
> 
> When i understand the Sources correct it has something to do with the
> value of the config variables. But i left them all on the default
> values:
> 
> CONFIG_XENO_DRIVERS_RTCAN_MSCAN=y
> CONFIG_XENO_DRIVERS_RTCAN_MSCAN_1=y
> CONFIG_XENO_DRIVERS_RTCAN_MSCAN_2=y
> CONFIG_XENO_DRIVERS_RTCAN_MSCAN_CLOCK=66000000
> CONFIG_XENO_DRIVERS_RTCAN_MSCAN_ALT=y
> # CONFIG_XENO_DRIVERS_RTCAN_MSCAN_PSC2 is not set

It did at least compile under Linux 2.6.14, but MODULE_PARM has been 
removed in 2.6.17 :-(. Attached is a patch to get the MSCAN driver 
working under Linux 2.6.17. Philippe or Jan, could you please apply it, 
thanks.

Also be aware that on the MPC5200B the MSCAN clock source used is the 
oscillator clock (SYS_XTAL_IN) while on the MPC5200 it is the IP bus 
clock (IP_CLK) due to hardware bugs (see chip errata). Likely 
SYS_XTAL_IN runs at 33 MHz on your system.

Wolfgang.