Re: [Xenomai-help] rtcan_mscan compilation.

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

Wolfgang Grandegger wrote:
> ...
> Index: ksrc/drivers/can/rtcan_internal.h
> ===================================================================
> --- ksrc/drivers/can/rtcan_internal.h	(revision 1695)
> +++ ksrc/drivers/can/rtcan_internal.h	(working copy)
> @@ -111,6 +111,10 @@
>  
>  #ifndef compat_module_int_param_array
>  #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,10)
> +# define compat_module_int_param(name) \
> +    MODULE_PARM(name, "i")
> +# define compat_module_charp_param(name) \
> +    MODULE_PARM(name, "s")
>  # define compat_module_byte_param_array(name, count) \
>      MODULE_PARM(name, "1-" __MODULE_STRING(count) "b")
>  # define compat_module_short_param_array(name, count) \
> @@ -118,6 +122,10 @@
>  # define compat_module_int_param_array(name, count) \
>      MODULE_PARM(name, "1-" __MODULE_STRING(count) "i")
>  #else
> +# define compat_module_int_param(name) \
> +    module_param(name, int, 0444)
> +# define compat_module_charp_param(name) \
> +    module_param(name, charp, 0444)
>  # define compat_module_byte_param_array(name, count) \
>      module_param_array(name, byte, NULL, 0444)
>  # define compat_module_short_param_array(name, count) \

No need, module_param comes even with 2.4. We only need wrapping for
parameter arrays (due to different semantics of the macro arguments).

So, this patch can be shorter... :)

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]