From: Jeff Garzik <jeff@garzik.org>
To: Al Viro <viro@ftp.linux.org.uk>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] minimal alpha pt_regs fixes
Date: Sat, 07 Oct 2006 11:08:39 -0400 [thread overview]
Message-ID: <4527C2F7.2010102@garzik.org> (raw)
In-Reply-To: <20061007131731.GC29920@ftp.linux.org.uk>
Al Viro wrote:
> diff --git a/include/asm-alpha/irq_regs.h b/include/asm-alpha/irq_regs.h
> new file mode 100644
> index 0000000..3dd9c0b
> --- /dev/null
> +++ b/include/asm-alpha/irq_regs.h
> @@ -0,0 +1 @@
> +#include <asm-generic/irq_regs.h>
ACK, of course, but I wonder if we can do something about these 1-line
header files.
Would it be reasonable to encourage developers to do something like
#ifdef ARCH_HAVE_FEATURE_FOO
#include <asm/foo.h>
#else
#include <asm-generic/foo.h>
#endif
to avoid these 1-line headers?
Jeff
next prev parent reply other threads:[~2006-10-07 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-07 13:17 [PATCH] minimal alpha pt_regs fixes Al Viro
2006-10-07 15:08 ` Jeff Garzik [this message]
2006-10-07 15:14 ` Al Viro
2006-10-07 17:49 ` Linus Torvalds
2006-10-07 18:27 ` Sam Ravnborg
2006-10-07 23:35 ` Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4527C2F7.2010102@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.