All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Minor coding style fix
Date: Sun, 08 Oct 2006 20:36:03 +0530	[thread overview]
Message-ID: <452913DB.4010409@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 103 bytes --]

Kernel generally follow the style 

if (func()) {
/* failed case */
} else {
/* success */
}


-aneesh

[-- Attachment #2: sys.c.diff --]
[-- Type: text/x-patch, Size: 366 bytes --]

diff --git a/kernel/sys.c b/kernel/sys.c
index 98489d8..55cb77c 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -517,7 +517,7 @@ EXPORT_SYMBOL_GPL(srcu_notifier_call_cha
 void srcu_init_notifier_head(struct srcu_notifier_head *nh)
 {
 	mutex_init(&nh->mutex);
-	if (init_srcu_struct(&nh->srcu) < 0)
+	if (init_srcu_struct(&nh->srcu))
 		BUG();
 	nh->head = NULL;
 }

             reply	other threads:[~2006-10-08 15:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-08 15:06 Aneesh Kumar K.V [this message]
2006-10-08 15:29 ` [PATCH] Minor coding style fix Jesper Juhl
2006-10-08 15:42   ` Jan Engelhardt
2006-10-08 17:18   ` Aneesh Kumar K.V
2006-10-09 14:39     ` Stefan Richter
  -- strict thread matches above, loose matches on Subject: below --
2017-03-27 14:34 [PATCH] minor " sfaragnaus
2017-03-29  7:18 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=452913DB.4010409@gmail.com \
    --to=aneesh.kumar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.