From: jim.cromie@gmail.com (Jim Cromie)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [patch] hwmon-sysfs.h: add _RO and _RW versions of
Date: Sun, 08 Oct 2006 16:30:01 +0000 [thread overview]
Message-ID: <45292789.5000003@gmail.com> (raw)
hi Jean,
1st attachment adds _RO and _RW versions to the following macros:
SENSOR_ATTR, SENSOR_DEVICE_ATTR,
SENSOR_ATTR_2, SENSOR_DEVICE_ATTR_2,
with these defined, the script (2nd attachment) will convert ~800 uses
(in 17 files) to the correct _RO/_RW version, and remove the linewraps.
The results compile cleanly (all modules in hwmon).
Is this something you'd consider applying ? If so, when ?
Theres obvious timing issues - since this patch touches many drivers,
which may have
work in-queue (yours or other hackers'). Its also why I sent the script
- the patch
it yields is 94KB, so the script is far more inspectable, and with the
script, you
can chose the optimal time(s) w/o synchronization hassles.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff.ro-rw.20061008.094436
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20061008/b684751b/attachment.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ro-rw-change
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20061008/b684751b/attachment-0001.pl
next reply other threads:[~2006-10-08 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-08 16:30 Jim Cromie [this message]
2006-10-10 9:42 ` [lm-sensors] [patch] hwmon-sysfs.h: add _RO and _RW versions of Jean Delvare
2006-10-11 4:38 ` Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45292789.5000003@gmail.com \
--to=jim.cromie@gmail.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.