All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@domain.hid>
To: xenomai-core <xenomai@xenomai.org>
Subject: [Xenomai-core] [BUG] rtf_put broken due to kernel 2.4 bug
Date: Mon, 09 Oct 2006 00:10:58 +0200	[thread overview]
Message-ID: <45297772.5080500@domain.hid> (raw)

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

Hi,

this issue

http://www.ussg.iu.edu/hypermail/linux/kernel/0610.1/0211.html

was revealed by the rtai fifo code. We currently have the double
__test_and_set_bit combination at least here:

http://www.rts.uni-hannover.de/xenomai/lxr/source/ksrc/skins/rtai/fifo.c#L309
(resolves to __test_and_set_bit via ipipe_test_and_stall_pipeline_from)
http://www.rts.uni-hannover.de/xenomai/lxr/source/ksrc/skins/rtai/fifo.c#L311

The effect on this code is that multiple rtf_put on an unconnected fifo
corrupts its queue.

I'm now awaiting the comment of the 2.4 maintainer, but we will still
have to cope with this issue on current 2.4 kernels. There is also the
risk that more spots are affected or will be affected in the future
given the embedded use of __test_and_set_bit in pipeline stalling commands.

Anyone any smart idea how to handle this? Should we simply include the
bitops patch in 2.4-x86-ipipe?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

             reply	other threads:[~2006-10-08 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-08 22:10 Jan Kiszka [this message]
2006-10-14 21:08 ` [Xenomai-core] [BUG] rtf_put broken due to kernel 2.4 bug Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45297772.5080500@domain.hid \
    --to=jan.kiszka@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.