All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter@lists.netfilter.org,
	Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>
Subject: Re: Compiling 1.3.6
Date: Mon, 09 Oct 2006 00:21:43 +0200	[thread overview]
Message-ID: <452979F7.9090205@netfilter.org> (raw)
In-Reply-To: <00be01c6e977$1ba6bcd0$0101a8c0@pcjorge>

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

Hi Patrick,

Jorge Bastos wrote:
> I was compiling the 1.3.6 version of iptables, agains my 2.6.19-rc1
> kernel version and i get this (it also happens with the final 2.6.18).
> Is there some livrary that needs an upgrade or am i missing something?
> I already tryed the svn last version and the same happens.

min_ip and max_ip type has been changed from u_int32_t to __be32 that is
not defined in userspace, this breaks iptables compilation. Attached a
patch that recovers the use of u_int32_t. I'm not sure if this is the
best fix so let me know what you think.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 721 bytes --]

[PATCH] Fix iptables compilation with support for iprange

iptables requires ipt_iprange.h that defines max_ip and min_ip as __be32
that is not defined in userspace.

Reported by Jorge Bastos.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Index: net-2.6/include/linux/netfilter_ipv4/ipt_iprange.h
===================================================================
--- net-2.6.orig/include/linux/netfilter_ipv4/ipt_iprange.h	2006-10-09 00:15:42.000000000 +0200
+++ net-2.6/include/linux/netfilter_ipv4/ipt_iprange.h	2006-10-09 00:15:55.000000000 +0200
@@ -8,7 +8,7 @@
 
 struct ipt_iprange {
 	/* Inclusive: network order. */
-	__be32 min_ip, max_ip;
+	u_int32_t min_ip, max_ip;
 };
 
 struct ipt_iprange_info

  reply	other threads:[~2006-10-08 22:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-06 18:41 Compiling 1.3.6 Jorge Bastos
2006-10-08 22:21 ` Pablo Neira Ayuso [this message]
2006-10-09 15:23   ` Patrick McHardy
2006-10-09 15:36     ` Pablo Neira Ayuso
2006-10-09 15:44       ` Pablo Neira Ayuso
2006-10-09 15:58         ` Marco Berizzi
2006-10-09 16:02           ` Patrick McHardy
2006-10-09 16:10             ` Marco Berizzi
2006-10-09 17:23               ` Patrick McHardy
2006-10-09 17:57                 ` Jorge Bastos
2006-10-09 16:02       ` Patrick McHardy
2006-10-19  6:06         ` [PATCH] iptables: ip6table version support and libip6t_multiport.fix Yasuyuki KOZAKAI
  -- strict thread matches above, loose matches on Subject: below --
2006-09-11  1:06 Laurence J. Lane
2006-10-02  1:37 ` Laurence J. Lane
2006-10-02  4:46   ` Yasuyuki KOZAKAI
2006-10-02 14:47     ` Rémi Denis-Courmont
2006-10-03 14:30       ` Yasuyuki KOZAKAI
     [not found]       ` <200610031430.k93EUJgA008197@toshiba.co.jp>
2006-10-03 19:58         ` Rémi Denis-Courmont
2006-10-12  8:11           ` Yasuyuki KOZAKAI
     [not found]           ` <200610120811.k9C8B4Pg002384@toshiba.co.jp>
2006-10-12 14:29             ` Rémi Denis-Courmont
2006-10-13  0:50               ` Yasuyuki KOZAKAI
     [not found]                 ` <200610190606.k9J66kRd002796@toshiba.co.jp>
2006-10-20 10:06                   ` Patrick McHardy
2006-10-20 11:48                     ` Yasuyuki KOZAKAI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=452979F7.9090205@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=netfilter@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.