From: Tejun Heo <htejun@gmail.com>
To: Joe Jin <lkmaillist@gmail.com>
Cc: linux-ide@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] libata: skip reset on bus not a device
Date: Mon, 09 Oct 2006 16:57:00 +0900 [thread overview]
Message-ID: <452A00CC.4080205@gmail.com> (raw)
In-Reply-To: <215036450610090044n56ec3a9dg62573a16d63ab00c@mail.gmail.com>
Joe Jin wrote:
>> > It's against libata development tree. So, you downloaded the tar.gz
>> and
>> > tested it?
>
> no, but at latest kernel 2.6.19-rc1 use the same tree as you said, and
> it also can worked
I see. It's irrelevant anyway.
>> And, one more thing to try. The following patch should fix your
>> problem. It's against v2.6.18.
>>
>
> while applied the patch, error info gone :)
>
> A question: if the status register return 0xFF means the device not exist?
> why not use ata_devchk()?
Many SATA controllers emulate TF registers and pass devchk even when no
device is attached. I don't know whether the two conditions can happen
together - 0xFF status is usually seen on PATA. Anyways, it's more
reliable to test 0xFF. Also, that's what driver/ide has been doing for
a long long time and we don't want to deviate from it if possible.
--
tejun
next prev parent reply other threads:[~2006-10-09 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-30 5:06 [PATCH] libata: skip reset on bus not a device Joe Jin
2006-09-30 14:14 ` Tejun Heo
2006-10-01 1:49 ` Joe Jin
2006-10-09 3:06 ` Tejun Heo
2006-10-09 6:54 ` Joe Jin
2006-10-09 7:00 ` Tejun Heo
2006-10-09 7:06 ` Tejun Heo
2006-10-09 7:44 ` Joe Jin
2006-10-09 7:57 ` Tejun Heo [this message]
2006-10-17 23:13 ` Jesse Brandeburg
2006-10-18 16:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452A00CC.4080205@gmail.com \
--to=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmaillist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.