From: Manu Abraham <abraham.manu@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Amit Choudhary <amit2030@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.19-rc1] drivers/media/dvb/bt8xx/dvb-bt8xx.c: check kmalloc() return value.
Date: Mon, 09 Oct 2006 12:44:50 +0400 [thread overview]
Message-ID: <452A0C02.90700@gmail.com> (raw)
In-Reply-To: <20061009083723.GA27728@aepfle.de>
Olaf Hering wrote:
> On Sun, Oct 08, Amit Choudhary wrote:
>
>> Description: Check the return value of kmalloc() in function frontend_init(), in file drivers/media/dvb/bt8xx/dvb-bt8xx.c.
>>
>> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
>>
>> diff --git a/drivers/media/dvb/bt8xx/dvb-bt8xx.c b/drivers/media/dvb/bt8xx/dvb-bt8xx.c
>> index fb6c4cc..14e69a7 100644
>> --- a/drivers/media/dvb/bt8xx/dvb-bt8xx.c
>> +++ b/drivers/media/dvb/bt8xx/dvb-bt8xx.c
>> @@ -665,6 +665,10 @@ static void frontend_init(struct dvb_bt8
>> case BTTV_BOARD_TWINHAN_DST:
>> /* DST is not a frontend driver !!! */
>> state = (struct dst_state *) kmalloc(sizeof (struct dst_state), GFP_KERNEL);
>> + if (!state) {
>> + printk("dvb_bt8xx: No memory\n");
>
> KERN_FOO loglevel is missing.
It shouldn't matter though.
Manu
prev parent reply other threads:[~2006-10-09 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 6:10 [PATCH 2.6.19-rc1] drivers/media/dvb/bt8xx/dvb-bt8xx.c: check kmalloc() return value Amit Choudhary
2006-10-09 8:34 ` Manu Abraham
2006-10-10 8:01 ` [stable] " Greg KH
2006-10-10 11:18 ` Manu Abraham
2006-10-10 16:31 ` Greg KH
2006-10-09 8:37 ` Olaf Hering
2006-10-09 8:44 ` Manu Abraham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452A0C02.90700@gmail.com \
--to=abraham.manu@gmail.com \
--cc=amit2030@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.