All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: bcollins@debian.org, Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firewire: handle sysfs errors
Date: Tue, 10 Oct 2006 08:52:44 -0400	[thread overview]
Message-ID: <452B979C.9030001@garzik.org> (raw)
In-Reply-To: <452B5BEE.4050407@s5r6.in-berlin.de>

Stefan Richter wrote:
> drivers/ieee1394/nodemgr.c: In function `fw_set_rescan':
> drivers/ieee1394/nodemgr.c:417: warning: 'rc' might be used
> uninitialized in this function
> 
> The rest of the patch looks OK.

shoops, sorry


> I get a lot more warn_unused_result warnings at other places in
> ieee1394/nodemgr.c and ieee1394/hosts.c though. I could fix them all up
> and fix this new warning in fw_set_rescan too if you don't mind...

That would be fantastic...

	Jeff



  reply	other threads:[~2006-10-10 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-10  6:48 [PATCH] firewire: handle sysfs errors Jeff Garzik
2006-10-10  8:38 ` Stefan Richter
2006-10-10 12:52   ` Jeff Garzik [this message]
2006-10-10 19:11     ` [PATCH 2.6.19-rc1 1/3] ieee1394: lock smaller region by host_num_alloc mutex Stefan Richter
2006-10-10 19:12       ` [PATCH 2.6.19-rc1 2/3] ieee1394: coding style in hosts.c Stefan Richter
2006-10-10 19:19         ` [PATCH 2.6.19-rc1 3/3] ieee1394: handle sysfs errors Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=452B979C.9030001@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@osdl.org \
    --cc=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.