From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH][Take 4] VNC authentification Date: Tue, 10 Oct 2006 09:04:09 -0500 Message-ID: <452BA859.2060306@us.ibm.com> References: <4524583D.8000109@us.ibm.com> <20061010131116.GA22928@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061010131116.GA22928@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" Cc: Ian Pratt , xen-devel@lists.xensource.com, Masami Watanabe List-Id: xen-devel@lists.xenproject.org Daniel P. Berrange wrote: > On Thu, Oct 05, 2006 at 10:28:15AM +0900, Masami Watanabe wrote: > >> Hi all, >> >> This is take 4 on VNC authentification. >> >> The specification is as mentioned at >> http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00666.html >> (However, password came to describe plain text) >> >> The difference is follows. >> - protocol_authtype() without the necessity was deleted. >> - The check on the protocol version was added. >> - And, some small modification. >> > > The patch loooks good to me - unless Anthony spots any further issues in > the VNC auth code, I'd say this is worth commiting to xen-unstable.hg > whe 3.0.4 development opens up. > Looks good to me too. Thanks Masami! Regards, Anthony Liguori > Regards, > Dan. >