From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: initrd change breaks binary compatibility Date: Tue, 10 Oct 2006 15:31:59 -0500 Message-ID: <452C033F.6010005@us.ibm.com> References: <20061010192848.GA795@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061010192848.GA795@totally.trollied.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John Levon Cc: xen-devel List-Id: xen-devel@lists.xenproject.org John Levon wrote: > This change in 3.0.3-testing-rc3: > > changeset: 11728:30f13007be3f > user: kfraser@localhost.localdomain > date: Mon Oct 09 13:50:00 2006 +0100 > files: tools/libxc/xc_linux_build.c > description: > [XEND] No need to decompress the initrd when building a domain. > > breaks binary compatibility. In particular, it breaks Solaris, which > expects both grub and xen to uncompress the initrd for us. And it does > seem odd to differ from grub's behaviour needlessly. > > I don't know what causes the broken Linux initrd's that the commit > message refers to, but it seems they need to be fixed another way. I suspect that we're actually broken here. I think the way we determine the uncompressed size (by reading the last couple bytes) is not something that can, in generally, be safely relied upon. We could work around this by decompressing the initrd and dynamically expanding the buffer we're decompressing to as needed. Regards, Anthony Liguori > regards, > john