Re: PATCH: fix memory leaks in matchpathcon.c

[Joshua Brindle <method@gentoo.org>]

Todd Miller wrote:
> The process_line() function does not clean up correctly on early 
> return in all cases.
> This diff does two things:
>
>  1) replaces usage of the non-standard %as scanf() format (which 
> conflicts with C99)
>       with simple strtok().  This does mean that line_buf is modified 
> but this variable is
>       only used as an argument to process_line() and is then freed.
>
>  2) adds a finish: label and ret variable that holds the return 
> value.  Instead of
>       returning early we just goto finish and let it clean things up 
> as needed.  This
>       does assume that free(NULL) is valid but that as been the case 
> since C89.
>
> As far as the memory leaks go, #2 is the important part.  I needed #1 
> for our
> port of libselinux to FreeBSD and Darwin.

Can you please split this patch into a bugfix patch (for the memory 
leak) and a patch to remove the non-standard formats?

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.