All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: netfilter@lists.netfilter.org, coreteam@netfilter.org,
	netfilter-devel@lists.netfilter.org
Subject: Re: [netfilter-core] linux-2.6.19-rc1 (commit ebf7a227) build failed
Date: Wed, 11 Oct 2006 10:41:35 +0200	[thread overview]
Message-ID: <452CAE3F.7040608@trash.net> (raw)
In-Reply-To: <200610110939.28328.toralf.foerster@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Toralf Förster wrote:
> net/built-in.o: In function `xt_connsecmark_init':
> xt_CONNSECMARK.c:(.init.text+0xed4): undefined reference to `need_conntrack'
> make: *** [.tmp_vmlinux1] Error 1

Thanks, fixed by this patch.

BTW, please report non-critical bugs to netfilter-devel only.
I know MAINTAINERS says to send them to coreteam@, I'm going
to fix that.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1333 bytes --]

[NETFILTER]: xt_CONNSECMARK: fix Kconfig dependencies

CONNSECMARK needs conntrack, add missing dependency to fix linking error
with CONNSECMARK=y and CONNTRACK=m.

Reported by Toralf Förster <toralf.foerster@gmx.de>.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 0ab5046ab83e4f0e88c40922701b2bc365f6aa09
tree 4add4ff88904c63e7ff20872f2faff015bbcbc28
parent 889d786a9211434b29e402a501d01a590b072d31
author Patrick McHardy <kaber@trash.net> Wed, 11 Oct 2006 10:39:47 +0200
committer Patrick McHardy <kaber@trash.net> Wed, 11 Oct 2006 10:39:47 +0200

 net/netfilter/Kconfig |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index ce94732..f619c65 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -209,7 +209,9 @@ config NETFILTER_XT_TARGET_SECMARK
 
 config NETFILTER_XT_TARGET_CONNSECMARK
 	tristate '"CONNSECMARK" target support'
-	depends on NETFILTER_XTABLES && (NF_CONNTRACK_SECMARK || IP_NF_CONNTRACK_SECMARK)
+	depends on NETFILTER_XTABLES && \
+		   ((NF_CONNTRACK && NF_CONNTRACK_SECMARK) || \
+		    (IP_NF_CONNTRACK && IP_NF_CONNTRACK_SECMARK))
 	help
 	  The CONNSECMARK target copies security markings from packets
 	  to connections, and restores security markings from connections

      reply	other threads:[~2006-10-11  8:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-11  7:39 linux-2.6.19-rc1 (commit ebf7a227) build failed Toralf Förster
2006-10-11  8:41 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=452CAE3F.7040608@trash.net \
    --to=kaber@trash.net \
    --cc=coreteam@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=netfilter@lists.netfilter.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.