Re: [PATCH] libnfnetlink

[Patrick McHardy <kaber@trash.net>]

Pablo Neira Ayuso wrote:
> what do you think about the following solution?
> 
> 
>>	if (len < sizeof(struct nlmsgerr)
>>	    || len < sizeof(struct nlmsghdr))
> 
> 
> errno = EBADMSG;
> 
> 
>>[...]
>>	if (addrlen != sizeof(peer))
> 
> 
> errno = EINVAL;
> 
> 
>>		return -1;
>>
>>	if (peer.nl_pid != 0)
> 
> 
> errno = ENOMSG;

The above all seem fine.

> 
>>		return -1;
>>
>>	nlh = (struct nlmsghdr *)buf;
>>	if (nlh->nlmsg_flags & MSG_TRUNC || status > len)
> 
> 
> errno = ENOSPC;

ENOSPC is fine for MSG_TRUNC, but it is a msghdr flag, not nlmsg.
status > len implies serious recvmsg brokeness and it doesn't
really make sense to check for kernel bugs, so I'd remove it.