From: Jeff Garzik <jeff@garzik.org>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: linux-scsi@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SCSI/qla2xxx: handle sysfs errors
Date: Thu, 12 Oct 2006 13:20:38 -0400 [thread overview]
Message-ID: <452E7966.7030206@garzik.org> (raw)
In-Reply-To: <20061012165734.GG3638@andrew-vasquezs-computer.local>
Andrew Vasquez wrote:
> NACK, please don't do this. SYSFS entries, albiet important, aren't
> necessarilly critical to a functioning driver. I'd rather the driver
> not error out.
As discussed before, the only errors thrown are either ENOMEM or EFAULT,
both of which are quite serious.
> Here's what I had stewing to address the must_check directives and
> qla2xxx:
If you're gonna change it that much, might as well use attribute groups.
Jeff
next prev parent reply other threads:[~2006-10-12 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 1:45 [PATCH] SCSI/qla2xxx: handle sysfs errors Jeff Garzik
2006-10-12 16:57 ` Andrew Vasquez
2006-10-12 17:20 ` Jeff Garzik [this message]
2006-10-12 17:31 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452E7966.7030206@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=andrew.vasquez@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.