All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivasa Ds <srinivasa@in.ibm.com>
To: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: [PATCH] 2.6.19-rc1: Fix build breakage with CONFIG_PPC32
Date: Fri, 13 Oct 2006 15:49:36 +0530	[thread overview]
Message-ID: <452F6838.6090605@in.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Linus
2.6.19-rc1 gives below error while compiling with CONFIG_PPC32.
 ===================================================================

 LD      fs/built-in.o
 GEN     .version
 CHK     include/linux/compile.h
 UPD     include/linux/compile.h
 CC      init/version.o
 LD      init/built-in.o
 LD      .tmp_vmlinux1
arch/powerpc/platforms/built-in.o: In function `flush_disable_caches':
(.text+0x96d4): undefined reference to `low_cpu_die'
======================================================
low_cpu_die() is defined under  CONFIG_PM || CONFIG_CPU_FREQ_PMAC  
options ,but while calling this function ,no care has been to taken to 
check these options. So please apply this fix,which solves the problem.

Signed-off-by: Srinivasa DS <srinivasa@in.ibm.com>





 



[-- Attachment #2: low_cpu_die.fix --]
[-- Type: text/plain, Size: 648 bytes --]

---
 arch/powerpc/platforms/powermac/smp.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-2.6.19-rc1/arch/powerpc/platforms/powermac/smp.c
===================================================================
--- linux-2.6.19-rc1.orig/arch/powerpc/platforms/powermac/smp.c
+++ linux-2.6.19-rc1/arch/powerpc/platforms/powermac/smp.c
@@ -867,7 +867,14 @@ int smp_core99_cpu_disable(void)
 	return 0;
 }
 
+#if defined(CONFIG_PM) || defined(CONFIG_CPU_FREQ_PMAC)
 extern void low_cpu_die(void) __attribute__((noreturn)); /* in sleep.S */
+#else
+void low_cpu_die(void)
+{
+}
+#endif
+
 static int cpu_dead[NR_CPUS];
 
 void cpu_die(void)

             reply	other threads:[~2006-10-13 10:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13 10:19 Srinivasa Ds [this message]
2006-10-16  4:38 ` [PATCH] 2.6.19-rc1: Fix build breakage with CONFIG_PPC32 Paul Mackerras
2006-10-18 12:04   ` Srinivasa Ds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=452F6838.6090605@in.ibm.com \
    --to=srinivasa@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.