All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@smiths-aerospace.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] CHANGELOG w/ status update: cmd_of.c, ft_build.c, vsprintf.c, long long print problem
Date: Fri, 13 Oct 2006 10:52:27 -0400	[thread overview]
Message-ID: <452FA82B.8050300@smiths-aerospace.com> (raw)
In-Reply-To: <E1GYOAX-00054u-EE@jdl.com>

Jon Loeliger wrote:
> So, like, the other day Jerry Van Baren mumbled:
>> OK, now for the rest of the subject line (sorry about that, but they are 
>> all intertwined via our respective git repositories).
>>
>> My git repository:
>> <http://www.cideas.us/git>
>>
>> Project for this discussion:
>> <http://www.cideas.us/cgi-bin/gitweb.cgi?p=u-boot/u-boot-pq2fads.git;a=summary>
> 
> Cool.  I'll try and track down some time to look at them!
> 
>> cmd_of.c, ft_build.c
>> --------------------
>> I've created a "of" command that allows you to dump all or part of a 
>> flattened tree.  To make the command more usable, I enhanced ft_build.c 
>> to do partial dumps.
> 
> Thank you.  You have saved me/Matthew from doing this. :-)

Yerwelcome.  Standing on the shoulders of giants and all that...

One thing I didn't "fix" is that the dump is missing the leading "/" for 
the root node, it prints
=> of 300000
  {
     model = "PQ2FADS";
     compatible = "MPC8260ADS";
     #address-cells = <00000001>;
     #size-cells = <00000001>;
     linux,phandle = <00000100>;
     :
     :
     };

instead of
=> of 300000
/ {
^-- missing "/"
     model = "PQ2FADS";
     compatible = "MPC8260ADS";
     #address-cells = <00000001>;
     #size-cells = <00000001>;
     linux,phandle = <00000100>;
     :
     :
     };

This happens because the "/" is put on the end of the old node path when 
concatenating the new node, rather than putting in on the start of the 
new node when a new node is found (this is a better approach except for 
the root node).  Since the first node has no "old" node to concatenate 
the "/" to, it never gets added.

I presume this is an error and will fix it.

>> At the moment, my copy of ft_build.c prints 8 byte entries as a double 
>> word "<%08x %08x>" rather than using 64 bit prints.
> 
> Hmmm... That might be an OK stop-gap, but I don't
> think we should count on that long term, of course.
> 
>> gvb
> 
> Thanks,
> jdl

gvb

  reply	other threads:[~2006-10-13 14:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13  1:14 [U-Boot-Users] Proposed CHANGELOG Generation Helpers Jon Loeliger
2006-10-13  9:52 ` Wolfgang Denk
2006-10-13 13:24   ` [U-Boot-Users] CHANGELOG w/ status update: cmd_of.c, ft_build.c, vsprintf.c, long long print problem Jerry Van Baren
2006-10-13 13:37     ` Wolfgang Denk
2006-10-13 13:45       ` Jerry Van Baren
2006-10-13 14:37     ` Jon Loeliger
2006-10-13 14:52       ` Jerry Van Baren [this message]
2006-10-13 14:28   ` [U-Boot-Users] Proposed CHANGELOG Generation Helpers Jon Loeliger
2006-10-13 14:32   ` Jon Loeliger
2006-10-13 15:33   ` Timur Tabi
2006-10-16  7:14     ` Wolfgang Denk
2006-10-16 14:36   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=452FA82B.8050300@smiths-aerospace.com \
    --to=gerald.vanbaren@smiths-aerospace.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.