From: Jiri Slaby <jirislaby@gmail.com>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] Char: stallion, use pr_debug macro
Date: Sun, 15 Oct 2006 10:19:47 +0159 [thread overview]
Message-ID: <4531EF3A.70101@gmail.com> (raw)
In-Reply-To: <4531E294.7050205@student.ltu.se>
Richard Knutsson wrote:
> Sorry for the late respond, just saw it...
>
> Jiri Slaby wrote:
>> stallion, use pr_debug macro
>>
> As it is a driver, is it not recommended to use the "dev_dbg()" found in
> include/linux/device.h, instead of pr_debug?
Only iff you have access to struct device. And you don't have here, but 2 prints
in stl_initpcibrd. This would be fixed in next patch serie...
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
next prev parent reply other threads:[~2006-10-15 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 21:07 [PATCH 1/7] Char: stallion, use pr_debug macro Jiri Slaby
2006-10-15 7:26 ` Richard Knutsson
2006-10-15 8:20 ` Jiri Slaby [this message]
2006-10-15 9:25 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4531EF3A.70101@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.