From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [patch rfc 1/3] xen arch header rework. Date: Mon, 16 Oct 2006 10:06:39 +0200 Message-ID: <45333D8F.8010400@suse.de> References: <4530C120020000780002437E@emea5-mh.id5.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4530C120020000780002437E@emea5-mh.id5.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: >>>> Gerd Hoffmann 10/11/06 11:16 AM >>> >> Jan Beulich wrote: >>>> + uint32_t unused; /* alignment */ >>> Could you use _pad[0-9]* here as is done elsewhere, so that scripts >> Fixed using "_attribute__((aligned (8)))" instead. > > If I remember right, we had complaints about such an approach already - > public headers shouldn't contain (unconditional) GNU-isms. Current patch adds one level of indirection for that, so the solaris guys can add something which works for sun cc. Latest version of the patch is here: http://www.suse.de/~kraxel/patches/kraxel-unstable-zweiblum-hg11751-quilt/learning-python.diff cheers, Gerd -- Gerd Hoffmann http://www.suse.de/~kraxel/julika-dora.jpeg