From: Gerd Hoffmann <kraxel@suse.de>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: Andrew Warfield <Andrew.Warfield@xensource.com>,
xen-devel@lists.xensource.com, Jan Beulich <jbeulich@novell.com>
Subject: Re: building blktap as a module
Date: Mon, 16 Oct 2006 13:45:31 +0200 [thread overview]
Message-ID: <453370DB.8090902@suse.de> (raw)
In-Reply-To: <C1591E06.28FE%Keir.Fraser@cl.cam.ac.uk>
Hi,
> 1. The one in blktap_release() - why? Standard semantics is for mmap
> regions to exist beyond the closing of the mapping device. Doesn't make much
> sense to do that here, but then again not really any need to explicitly
> disallow it (and add extra code to enforce).
The linux kernel does call the drivers release() method when the last
reference is gone. If you call close() with mappings still being
active, then ->release() is _not_ called when you close the file handle
but when the last mapping is unmapped. Thus there is no point in trying
to handle active mappings there ;)
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
http://www.suse.de/~kraxel/julika-dora.jpeg
next prev parent reply other threads:[~2006-10-16 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 9:48 building blktap as a module Jan Beulich
2006-10-16 10:31 ` Keir Fraser
2006-10-16 11:45 ` Gerd Hoffmann [this message]
2006-10-16 12:56 ` Keir Fraser
2006-10-16 14:07 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453370DB.8090902@suse.de \
--to=kraxel@suse.de \
--cc=Andrew.Warfield@xensource.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.