From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_marvell: Marvell 6101/6145 PATA driver
Date: Mon, 16 Oct 2006 19:48:41 -0400 [thread overview]
Message-ID: <45341A59.6000402@pobox.com> (raw)
In-Reply-To: <20061016163134.4560d253.akpm@osdl.org>
Andrew Morton wrote:
> On Mon, 16 Oct 2006 16:40:06 +0100
> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
>> +static int marvell_pre_reset(struct ata_port *ap)
>> +{
>> + struct pci_dev *pdev = to_pci_dev(ap->host->dev);
>> + u32 devices;
>> + unsigned long bar5;
>> + void __iomem *barp;
>> + int i;
>> +
>> + /* Check if our port is enabled */
>> +
>> + bar5 = pci_resource_start(pdev, 5);
>> + barp = ioremap(bar5, 0x10);
>
> hm. pci_resource_start() returns a possibly-64-bit resource_size_t
> nowadays. But ioremap() doesn't know how to remap such a thing.
These days, pci_iomap() should be used anyway.
Jeff
next prev parent reply other threads:[~2006-10-16 23:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 15:40 [PATCH] pata_marvell: Marvell 6101/6145 PATA driver Alan Cox
2006-10-16 23:31 ` Andrew Morton
2006-10-16 23:48 ` Jeff Garzik [this message]
2006-10-17 13:32 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45341A59.6000402@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.