From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Heath Subject: Re: Re: [PATCH 01/04] Kexec / Kdump: Generic code Date: Wed, 18 Oct 2006 10:49:08 -0500 Message-ID: <45364CF4.3030309@brainfood.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Ian Pratt , Kazuo Moriwaka , xen-devel@lists.xensource.com, Akio Takebe , magnus.damm@gmail.com, Isaku Yamahata , Magnus Damm , Horms List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > On 18/10/06 1:56 am, "Horms" wrote: > >>> I'll check this in, so please just get rid of the if(xchg()) hacky >>> workaround. >> I have to say that I entirely disagree with your solution. >> I think the solution is to get rid of -Werror. But I will >> remove the if(xchg()) foo as you request. > > Holy crap! Getting rid of Werror makes Wall much less useful. We're too lazy > to scan build output for warnings if they don't break the build. I wrote a script that I used when I was working on kaffe. It would scan the build output, and sort warnings based on the -W option that produces them. It'd then give output sorted by warning option, and file. Made it much easier to work with. I should put that up someplace. Was really handy when a warning was in some .h file, so would be shown several thousand times in the build log, but was really only one problem.