From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Date: Wed, 18 Oct 2006 19:12:19 +0000 Subject: Re: [KJ] [PATCH] OOM killer meets userspace headers Message-Id: <45367C93.3040804@yahoo.com.au> List-Id: References: <20061018145305.GA5345@martell.zuzino.mipt.ru> <453642D1.1010302@yahoo.com.au> <20061018184655.GC5345@martell.zuzino.mipt.ru> In-Reply-To: <20061018184655.GC5345@martell.zuzino.mipt.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexey Dobriyan Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org Alexey Dobriyan wrote: > On Thu, Oct 19, 2006 at 01:05:53AM +1000, Nick Piggin wrote: > >>>+#define OOM_ADJUST_MIN (-16) >>>+#define OOM_ADJUST_MAX 15 >> >>Why do you need the () for the -ves? > > > -16 is two tokens. Not that someone is going to do huge arithmetic with > OOM adjustments and screwup himself, but still... How can they screw themselves up? AFAIKS, the - directly to the left of the literal will bind more tightly than any other valid operator. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161106AbWJRTMf (ORCPT ); Wed, 18 Oct 2006 15:12:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161264AbWJRTMf (ORCPT ); Wed, 18 Oct 2006 15:12:35 -0400 Received: from smtp108.mail.mud.yahoo.com ([209.191.85.218]:10169 "HELO smtp108.mail.mud.yahoo.com") by vger.kernel.org with SMTP id S1161106AbWJRTMe (ORCPT ); Wed, 18 Oct 2006 15:12:34 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=oNC5A7Brh04Kz8s1RllnQHcBWcVVNwVScWZXV73+tI0Na/ucPi1yoDLfj/JDFr0pChhvYFvohBY6il2gaMkXzjJAwGLZQF+WUL4qu2m/Vnl9c6Srty1GYHsYcWo9wIHQVM9ABuCjf/Gnk4vslwtnZSKzlrw+dtgpShoFJ48gamw= ; Message-ID: <45367C93.3040804@yahoo.com.au> Date: Thu, 19 Oct 2006 05:12:19 +1000 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1 X-Accept-Language: en MIME-Version: 1.0 To: Alexey Dobriyan CC: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org Subject: Re: [PATCH] OOM killer meets userspace headers References: <20061018145305.GA5345@martell.zuzino.mipt.ru> <453642D1.1010302@yahoo.com.au> <20061018184655.GC5345@martell.zuzino.mipt.ru> In-Reply-To: <20061018184655.GC5345@martell.zuzino.mipt.ru> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Alexey Dobriyan wrote: > On Thu, Oct 19, 2006 at 01:05:53AM +1000, Nick Piggin wrote: > >>>+#define OOM_ADJUST_MIN (-16) >>>+#define OOM_ADJUST_MAX 15 >> >>Why do you need the () for the -ves? > > > -16 is two tokens. Not that someone is going to do huge arithmetic with > OOM adjustments and screwup himself, but still... How can they screw themselves up? AFAIKS, the - directly to the left of the literal will bind more tightly than any other valid operator. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com