From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH] Error message for device not found at
	blkif.py
Date: Wed, 18 Oct 2006 15:59:30 -0500
Message-ID: <453695B2.9080307@us.ibm.com>
References: <20061018200845.GB16266@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20061018200845.GB16266@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Glauber de Oliveira Costa <gcosta@redhat.com>, xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Instead of throwing a VmError, could you subclass VmError with a more 
specific error and throw that?

That will pass higher level info about the error to xm which means we 
can do a better job in there (this is especially important when we 
eventually localize xm).

Thanks,

Anthony Liguori


Glauber de Oliveira Costa wrote:
> Hi,
> 
> if blkdev_name_to_number() fails to assign a number to the specified
> device, it returns None, causing a far-away-from-self-explanatory
> message to be delivered. Better test for this condition and say exactly
> what happened.
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> --- xen-3.0.3-testing-11633/./tools/python/build/lib.linux-x86_64-2.4/xen/xend/server/blkif.py.orig	2006-09-28 18:52:39.000000000 -0400
> +++ xen-3.0.3-testing-11633/./tools/python/build/lib.linux-x86_64-2.4/xen/xend/server/blkif.py	2006-10-18 15:58:28.000000000 -0400
> @@ -81,6 +81,9 @@ class BlkifController(DevController):
>                           'acm_policy' : policy})
>  
>          devid = blkif.blkdev_name_to_number(dev)
> +        if not devid:
> +            raise VmError('Unable to find number for device (%s)'%(dev))
> +
>          front = { 'virtual-device' : "%i" % devid,
>                    'device-type' : dev_type
>                  }
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel