From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: linville@tuxdriver.com, Daniel Drake <dsd@gentoo.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bcm43xx: Readd dropped assignment
Date: Wed, 18 Oct 2006 16:10:21 -0500 [thread overview]
Message-ID: <4536983D.40603@lwfinger.net> (raw)
In-Reply-To: <200610181640.01140.mb@bu3sch.de>
Michael Buesch wrote:
> On Wednesday 18 October 2006 01:12, Daniel Drake wrote:
>> Larry Finger pointed out a problem with my ieee80211 IV/ICV stripping patch,
>> which I forgot about. Sorry about that.
>>
>> The patch readds the frame_ctl assignment which was accidently dropped.
>>
>> Signed-off-by: Daniel Drake <dsd@gentoo.org>
>
> Whoops. Please merge this as fast as possible, John.
> That's a real bug which prevents RX from working.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
>> Index: linux/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
>> ===================================================================
>> --- linux.orig/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
>> +++ linux/drivers/net/wireless/bcm43xx/bcm43xx_xmit.c
>> @@ -543,6 +543,7 @@ int bcm43xx_rx(struct bcm43xx_private *b
>> break;
>> }
>>
>> + frame_ctl = le16_to_cpu(wlhdr->frame_ctl);
>> switch (WLAN_FC_GET_TYPE(frame_ctl)) {
>> case IEEE80211_FTYPE_MGMT:
>> ieee80211_rx_mgt(bcm->ieee, wlhdr, &stats);
>>
>
next prev parent reply other threads:[~2006-10-18 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 23:12 [PATCH] bcm43xx: Readd dropped assignment Daniel Drake
2006-10-18 14:40 ` Michael Buesch
2006-10-18 21:10 ` Larry Finger [this message]
2006-10-21 3:29 ` Dave Jones
2006-10-21 3:42 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4536983D.40603@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=dsd@gentoo.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.