From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] Error message for device not found at blkif.py Date: Wed, 18 Oct 2006 16:41:12 -0500 Message-ID: <45369F78.4090409@us.ibm.com> References: <20061018200845.GB16266@redhat.com> <453695B2.9080307@us.ibm.com> <20061018212846.GC16266@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061018212846.GC16266@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Glauber de Oliveira Costa Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Glauber de Oliveira Costa wrote: > On Wed, Oct 18, 2006 at 03:59:30PM -0500, Anthony Liguori wrote: > >> Instead of throwing a VmError, could you subclass VmError with a more >> specific error and throw that? >> > Fore sure I can. But what does this condition have so differently from > others that justifies that for it only? Although I agree with you that > such a specificiness is good, VmError is being thrown everywhere, meaning > that your proposal would require touching a great amount of code change. > Is there any plans/opposals for that? > > BTW, check out tools/python/xen/xend/XendError.py for an example of where we're doing this. Regards, Anthony Liguori