From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-f174.google.com (mail-ea0-f174.google.com [209.85.215.174]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 5CB7EE01409 for ; Fri, 21 Jun 2013 07:24:28 -0700 (PDT) Received: by mail-ea0-f174.google.com with SMTP id o10so4596752eaj.19 for ; Fri, 21 Jun 2013 07:24:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type:x-gm-message-state; bh=7E862REQUBt8Mnx1yWzlS4wDP6NyP/NgZqaUCqwNDQ8=; b=RUw0gsrBe4BghoBlR+e/4YzrHga7w2N/7qayQuUnAMl8c2S9refIrUKpA6EmsVKSo5 Y8+yvev/umN4/SkyjEfg8u+wDz6hAStZu9J1/3IC3IcS3/5/+OgLlsMXh70dK+JSyY0q z6/Xpxf905opXLv34J8kCc5egvtXWgOi6wDCgHiXuoux3raEClJfT2LdLqR46M4MIdJ6 Rds/FnuXLQEZEvOvfyRCJj15KoWt6Z4bTJ2mc5fLrNgjylf85N1k5JCQN6vbsPJvbq9x wW6F/VfWhw0yFn8SNTrJXUVnM//pxe/sGXxiZs6vwMk4uk1W3w9IZj6PK00pXIaocOVd xPuw== X-Received: by 10.15.63.67 with SMTP id l43mr2399000eex.5.1371824667120; Fri, 21 Jun 2013 07:24:27 -0700 (PDT) Received: from rudolf.localnet (ppp-82-135-84-132.dynamic.mnet-online.de. [82.135.84.132]) by mx.google.com with ESMTPSA id w43sm8103121eez.6.2013.06.21.07.24.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 21 Jun 2013 07:24:26 -0700 (PDT) From: Thomas Senyk To: Otavio Salvador Date: Fri, 21 Jun 2013 16:24:15 +0200 Message-ID: <4537047.nTOJiz2yF2@rudolf> Organization: Pelagicore AG User-Agent: KMail/4.10.4 (Linux/3.9.6-1-ARCH; KDE/4.10.4; x86_64; ; ) In-Reply-To: References: <2169791.BFDmuhoxsk@rudolf> <4597598.jNyVYkh5e2@rudolf> MIME-Version: 1.0 X-Gm-Message-State: ALoCoQlJFP7DDr3yOlEFsPNiQ0IDrLgVvHSD3Oxceo18Q0gIPe9psMEGSvxyCQbphxkP4Fs7Ig2i Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm][PATCH] Adding -lEGL and -lGAL to glesv2.pc X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jun 2013 14:24:36 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, 21 June, 2013 10:43:12 Otavio Salvador wrote: > On Fri, Jun 21, 2013 at 10:02 AM, Thomas Senyk > > wrote: > > On Friday, 21 June, 2013 9:35:15 Otavio Salvador wrote: > >> On Fri, Jun 21, 2013 at 8:52 AM, Thomas Senyk > >> > >> wrote: > >> > On Friday, 21 June, 2013 11:08:19 Thomas Senyk wrote: > >> >> On Thursday, 20 June, 2013 17:33:00 Otavio Salvador wrote: > >> >> > On Thu, Jun 20, 2013 at 5:00 PM, Otavio Salvador > >> >> > > >> >> > wrote: > >> >> > > On Thu, Jun 20, 2013 at 11:31 AM, Thomas Senyk > >> >> > > > >> >> > > wrote: > >> >> > >> From: Thomas Senyk > >> >> > >> > >> >> > >> libGLESv2 has undefined symbols, which get provided by libEGL and > >> >> > >> libGAL, > >> >> > >> but libGLESv2 has no implicit 'link' to those libs. > >> >> > >> So if you link against libGLESv2 but not against libEGL and > >> >> > >> libGAL, > >> >> > >> you'll get 'undefined symbol'-errors. > >> >> > >> > >> >> > >> Signed-off-by: Thomas Senyk > >> >> > > > >> >> > > Please change your short description to include the recipe name: > >> >> > > > >> >> > > gpu-viv-bin-mx6q: Add ... > >> >> > > > >> >> > > libGLESv2 ... > >> >> > > > >> >> > > Signed-off-by: ... > >> >> > >> >> ah, right! sorry > >> >> > >> >> > I did this locally and pushed to master-next. Please follow these > >> >> > guidelines when doing the commit log so it easy finding which > >> >> > changes > >> >> > might affect each recipe. > >> >> > >> >> Thanks and I keep in mind for next time! > >> >> > >> >> > Regards, > >> >> > > >> >> > -- > >> >> > Otavio Salvador O.S. Systems > >> >> > http://www.ossystems.com.br http://projetos.ossystems.com.br > >> >> > Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 > >> > > >> > I've just spotted two other things: > >> > > >> > a: I skipped glesv1_cm.pc because I've not used it so far, but I looks > >> > like it has the same gco* and eglWaitClient symbols as "*UND*" as > >> > libGLESv2, so maybe it should be linked the same way > >> > >> Can you update the patch and send a v2? > >> > >> > and more importantly (at least for me): > >> > > >> > b: egl.pc (and glesv1_cm.pc) has: > >> > "Requires.private: libdrm x11 xext xdamage xfixes xcb" > >> > > >> > this must be removed as it's wrong and harmful for non-x11 builds. > >> > If this is a 'must-have' for x11 builds, we need to have two files. > >> > Any thought from somebody who has done a x11 build on 4.0.0 drivers? > >> > >> I agree; but it seems we'll need to handle it with two files. One for > >> 'fb' and another for 'x11'. The used one can be choosen by the backend > >> variable in use. > >> > >> Can you take a look on this? > > > > Yes. I'll do it in two commits (one v2 for the glesv1 change and another > > one for the x11 vs. non-x11) ... unless you want it in one? that's ok > > with me as well. > > Yes; do it in two commits. k, commit 1 is ready. I'll send them in one mail when commit 2 is done > > > The idea for x11 vs. non-x11 I have right now would be: > > > > SRC_URI += "${@base_contains("DISTRO_FEATURES", "x11", " file://pkg- > > config_x11/egl.pc ", " file://egl.pc ", d)}" > > (for all 3 files) > > > > ... so: having a 'neutral' version in gpu-viv-bin-mx6q/ and having the x11 > > version in gpu-viv-bin-mx6q/pkg-config_x11/ > > > > does that sound reasonable? > > Almost but avoid subdirs. I'd use: > > egl_x11.pc > egl_fb.pc > > and use distro features in do_install, to choose. k! Although I would do a "general" egl.pc for all non-x11 (fb and dfb) as I've no idea if dfb needs anything special? If there is anything special about dfb I should know of, or if a plain copy is is actually the right thing to do: let me know and I'll do 3 versions of each file > > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.br http://projetos.ossystems.com.br > Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750