From: Michael Tokarev <mjt@tls.msk.ru>
To: Andrew Morton <akpm@osdl.org>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jeff Garzik <jgarzik@pobox.com>,
Paul Mackerras <paulus@samba.org>,
Mirko Lindner <mlindner@syskonnect.de>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 4/6] net: use bitrev8
Date: Fri, 20 Oct 2006 13:54:44 +0400 [thread overview]
Message-ID: <45389CE4.7050406@tls.msk.ru> (raw)
In-Reply-To: <20061019133951.1d463173.akpm@osdl.org>
Andrew Morton wrote:
> On Thu, 19 Oct 2006 01:46:47 +0900
> Akinobu Mita <akinobu.mita@gmail.com> wrote:
>
>> Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers.
>>
[]
>> ===================================================================
>> --- work-fault-inject.orig/drivers/net/Kconfig
>> +++ work-fault-inject/drivers/net/Kconfig
>> @@ -2500,6 +2500,7 @@ config DEFXX
>> config SKFP
>> tristate "SysKonnect FDDI PCI support"
>> depends on FDDI && PCI
>> + select BITREVERSE
>> ---help---
>> Say Y here if you have a SysKonnect FDDI PCI adapter.
>> The following adapters are supported by this driver:
>
[]
> But select is problematic and I do wonder whether it'd be simpler to just
> link the thing into vmlinux.
Why it's problematic? Maintenance costs of various missing selects?
I don't want extra stuff in kernel (vmlinux) if it's not used.
/mjt
prev parent reply other threads:[~2006-10-20 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 16:46 [PATCH 4/6] net: use bitrev8 Akinobu Mita
2006-10-19 20:39 ` Andrew Morton
2006-10-20 2:50 ` Akinobu Mita
2006-10-20 9:54 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45389CE4.7050406@tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=akinobu.mita@gmail.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@syskonnect.de \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.