From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH] Raise DevError for device not found at
	blkif.py
Date: Fri, 20 Oct 2006 10:54:51 -0500
Message-ID: <4538F14B.6080309@us.ibm.com>
References: <20061020160201.GE5677@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20061020160201.GE5677@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Glauber de Oliveira Costa wrote:
> Sorry if you get it twice. I have no idea why wasn't it delivered.
> Follows:
>
>
> Anthony,
>
> Hope this is a better error raising for the device not found
> construction in blkif.py. I imagine this Error can be used for
> generic device-related errors during Vm Construction.
>   

Looks okay to me.

Regards,

Anthony Liguori

> ------------------------------------------------------------------------
>
> --- xen-3.0.3-testing-11633/tools/python/xen/xend/XendError.py.orig	2006-10-20 08:09:50.000000000 -0400
> +++ xen-3.0.3-testing-11633/tools/python/xen/xend/XendError.py	2006-10-20 08:11:36.000000000 -0400
> @@ -36,4 +36,7 @@ class VmError(XendError):
>      """Vm construction error."""
>  
>      pass
> +class DevError(VmError):
> +    """Device probing/constructing"""
>  
> +    pass
> --- xen-3.0.3-testing-11633/tools/python/build/lib.linux-x86_64-2.4/xen/xend/server/blkif.py.orig	2006-09-28 18:52:39.000000000 -0400
> +++ xen-3.0.3-testing-11633/tools/python/build/lib.linux-x86_64-2.4/xen/xend/server/blkif.py	2006-10-20 08:23:53.000000000 -0400
> @@ -23,7 +23,7 @@ import string
>  from xen.util import blkif
>  from xen.util import security
>  from xen.xend import sxp
> -from xen.xend.XendError import VmError
> +from xen.xend.XendError import VmError,DevError
>  
>  from xen.xend.server.DevController import DevController
>  
> @@ -81,6 +81,9 @@ class BlkifController(DevController):
>                           'acm_policy' : policy})
>  
>          devid = blkif.blkdev_name_to_number(dev)
> +        if not devid:
> +            raise DevError('Unable to find number for device (%s)'%(dev))
> +
>          front = { 'virtual-device' : "%i" % devid,
>                    'device-type' : dev_type
>                  }
>