From: Kevin Hilman <khilman@mvista.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab debug and ARCH_SLAB_MINALIGN don't get along
Date: Fri, 20 Oct 2006 09:22:11 -0700 [thread overview]
Message-ID: <4538F7B3.4020207@mvista.com> (raw)
In-Reply-To: <84144f020610200156t1745b3d6xee0b0a24e6a1bba5@mail.gmail.com>
Pekka Enberg wrote:
> On 10/19/06, Kevin Hilman <khilman@mvista.com> wrote:
>> When CONFIG_SLAB_DEBUG is used in combination with ARCH_SLAB_MINALIGN,
>> some debug flags should be disabled which depend on BYTES_PER_WORD
>> alignment.
>>
>> The disabling of these debug flags is not properly handled when
>> BYTES_PER_WORD < ARCH_SLAB_MEMALIGN < cache_line_size()
>>
>> This patch fixes that and also adds an alignment check to
>> cache_alloc_debugcheck_after() when ARCH_SLAB_MINALIGN is used.
>
> You forgot to mention which case you are fixing in the patch
> description (that is, SLAB_HWCACHE_ALIGN, when cache_line_size() >
> BYTES_PER_WORD) which made the patch bit hard to decipher. Anyway,
> looks good, thanks!
Hi Pekka,
I found this on an ARM platform where ARCH_SLAB_MINALIGN=8, and the
default SLAB_HWCACHE_ALIGN is set also.
The ARM EABI requires 8-byte alignment to take full advantage of 8-byte
loads/stores for ARM arch >= v5.
Kevin
prev parent reply other threads:[~2006-10-20 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 19:57 [PATCH] slab debug and ARCH_SLAB_MINALIGN don't get along Kevin Hilman
2006-10-20 8:56 ` Pekka Enberg
2006-10-20 16:22 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4538F7B3.4020207@mvista.com \
--to=khilman@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.