All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Cohen <david.cohen@indt.org.br>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] McBSP dependence for DSP on ARCH_OMAP1 is missing
Date: Fri, 20 Oct 2006 16:29:58 -0400	[thread overview]
Message-ID: <453931C6.9080209@indt.org.br> (raw)

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi,

I've tried to compile an up-to-dated kernel tree configured for h3. I
got some errors due to the McBSP depends on OMAP_DSP if ARCH_OMAP1 is
set, as we can see at these lines from "arch/arm/plat-omap/mcbsp.c":

(...)
#ifdef CONFIG_ARCH_OMAP1
static void omap_mcbsp_dsp_request(void)
{
    if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
        omap_dsp_request_mem();

(...)
#endif
(...)

So, I've made this minimal patch to deal with this problem. It worked
well for me. But I put, also, CONFIG_OMAP_DSP=y as default on h3 config
file to keep the OMAP_MCBSP as default too.

BR,

David Cohen

[-- Attachment #2: diff_kconfig_mcbsp_h3.patch --]
[-- Type: text/plain, Size: 908 bytes --]

Signed-off-by: David Cohen <david.cohen@indt.org.br>
---
diff --git a/arch/arm/configs/omap_h3_1710_defconfig b/arch/arm/configs/omap_h3_1710_defconfig
index bc9cb6b..6cbdbe1 100644
--- a/arch/arm/configs/omap_h3_1710_defconfig
+++ b/arch/arm/configs/omap_h3_1710_defconfig
@@ -136,7 +136,7 @@ CONFIG_OMAP_ARM_168MHZ=y
 # CONFIG_OMAP_ARM_120MHZ is not set
 # CONFIG_OMAP_ARM_60MHZ is not set
 # CONFIG_OMAP_ARM_30MHZ is not set
-# CONFIG_OMAP_DSP is not set
+CONFIG_OMAP_DSP=y
 
 #
 # Processor Type
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index 2b56996..0ab87ff 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -103,7 +103,7 @@ config OMAP_STI_CONSOLE
 
 config OMAP_MCBSP
 	bool "McBSP support"
-	depends on ARCH_OMAP
+	depends on (ARCH_OMAP1 && OMAP_DSP) || ARCH_OMAP2
 	default y
 	help
 	  Say Y here if you want support for the OMAP Multichannel

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2006-10-20 20:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-20 20:29 David Cohen [this message]
2006-10-23 13:18 ` [PATCH] McBSP dependence for DSP on ARCH_OMAP1 is missing Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453931C6.9080209@indt.org.br \
    --to=david.cohen@indt.org.br \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.