From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Courtier-Dutton Subject: Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums. Date: Sat, 21 Oct 2006 17:13:47 +0100 Message-ID: <453A473B.1000206@superbug.demon.co.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from anchor-post-36.mail.demon.net (anchor-post-36.mail.demon.net [194.217.242.86]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 42FF3152 for ; Sat, 21 Oct 2006 18:13:53 +0200 (MEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Jaroslav Kysela Cc: ALSA development List-Id: alsa-devel@alsa-project.org Jaroslav Kysela wrote: > On Fri, 13 Oct 2006, James Courtier-Dutton wrote: > >> + {" Playback Enum", CTL_PLAYBACK_ENUM}, >> + {" Capture Enum", CTL_CAPTURE_ENUM}, >> + {" Enum", CTL_GLOBAL_ENUM}, > > I don't like this. We already know, that it's the enum type, so it's not > required to put this type to control id name again. > > Could you just check, if control id name ends with " Capture" or > " Playback" words and set CTL_XXXX_ENUM according that? > Is did it that way, for consistency. If you look at the naming of switches, volumes, I just used the same pattern for enums. James ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642