From: Jeff Garzik <jeff@garzik.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Jouni Malinen <jkm@devicescape.com>,
Andrew Morton <akpm@osdl.org>,
netdev@vger.kernel.org, Jean Tourrilhes <jt@hpl.hp.com>
Subject: Re: Please pull 'we21-fix' branch of wireless-2.6.git
Date: Sat, 21 Oct 2006 14:12:34 -0400 [thread overview]
Message-ID: <453A6312.3030207@garzik.org> (raw)
In-Reply-To: <20061019215647.GA18217@tuxdriver.com>
John W. Linville wrote:
> Jeff,
>
> Here is my ugly patch to fix userland ABI compatibility for WE-21.
> It tries to detect WE <= 20 by the request length or the inclusion of
> '\0' in the length for the ESSID and NICKN ioctls. If it finds that,
> it temporarily adjusts the length value and puts it back before
> reporting back to userland.
>
> It is possible that there are more elegant solutions that work, but
> I'm not totally convinced that they truly preserve the ABI as desired.
> Please see the discussion earlier in this thread if you are interested.
>
> I'm aware that checking for '\0' is problematic, since that technically
> is a valid SSID character even at the end of the SSID. I'm afraid
> we will just have to live with that limitation.
>
> I have the single patch on its own "clean" branch from Linus's tree of
> a few days ago. That way you can pull just this fix without concern
> about picking-up the other fixes which I posted a few days ago,
> in case you haven't reviewed them yet.
>
> Obviously, this is intended for 2.6.19.
>
> Thanks,
>
> John
> ---
>
> The following changes since commit 51018b0a3160d253283173c2f54f16746cee5852:
> Ulrich Drepper:
> make UML compile (FC6/x86-64)
>
> are found in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/wireless-2.6.git we21-fix
pulled, after adding "git/linville/" to the URL...
Jeff
prev parent reply other threads:[~2006-10-21 18:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 16:31 Request to postpone WE-21 Jean Tourrilhes
2006-10-05 20:49 ` John W. Linville
2006-10-05 21:21 ` Jean Tourrilhes
2006-10-05 21:57 ` Jouni Malinen
2006-10-05 22:07 ` Jean Tourrilhes
2006-10-05 22:37 ` Jeff Garzik
2006-10-05 22:12 ` Jean Tourrilhes
2006-10-05 22:15 ` Jouni Malinen
2006-10-05 22:20 ` Jean Tourrilhes
2006-10-10 19:40 ` John W. Linville
2006-10-10 20:28 ` Jean Tourrilhes
2006-10-19 21:56 ` Please pull 'we21-fix' branch of wireless-2.6.git John W. Linville
2006-10-19 22:10 ` Jean Tourrilhes
2006-10-21 18:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453A6312.3030207@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=jkm@devicescape.com \
--cc=jt@hpl.hp.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.