From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp104.mail.mud.yahoo.com ([209.191.85.214]:19593 "HELO smtp104.mail.mud.yahoo.com") by vger.kernel.org with SMTP id S1751143AbWJWBt6 (ORCPT ); Sun, 22 Oct 2006 21:49:58 -0400 Message-ID: <453C1FB5.9070007@yahoo.com.au> Date: Mon, 23 Oct 2006 11:49:41 +1000 From: Nick Piggin MIME-Version: 1.0 Subject: Re: dealing with excessive includes References: <20061018091944.GA5343@martell.zuzino.mipt.ru> <200610230242.58647.ak@suse.de> <20061023010812.GE25210@parisc-linux.org> <200610230331.16573.ak@suse.de> <20061023013604.GF25210@parisc-linux.org> In-Reply-To: <20061023013604.GF25210@parisc-linux.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org To: Matthew Wilcox Cc: Andi Kleen , Geert Uytterhoeven , Randy Dunlap , Stefan Richter , Al Viro , Linus Torvalds , Alexey Dobriyan , Linux Kernel Development , linux-arch@vger.kernel.org List-ID: Matthew Wilcox wrote: > Let me try to explain the problem again, because what you wrote has > nothing to do with the problem. > > canonicalize_irq() is defined in . No .c file should be > including in order to get it. It should be including > , which will indirectly pull in > > add_wait_queue() is defined in . .c files wishing to use > add_wait_queue() should be including rather than relying > on it being pulled in through some other path. > > This needs annotations to fix, or a big bag of unreliable heuristics. Does fixing it really fix anything? I agree that cleaning it all up would be great. But the aim should be to make less work for developers, rather than more. If you have an #ifndef _LINUX_INTERRUPT_H #error ... That almost explicitly tells you which is the correct file to include to get all definitions from this file. Wouldn't that help? -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com