From: Tejun Heo <htejun@gmail.com>
To: Uwe Koziolek <uwe.koziolek@gmx.net>
Cc: Jim Paris <jim@jtan.com>,
linux-ide@vger.kernel.org, muthas@mit.edu, fragmede@gmail.com,
David Wang <touch@sis.com>
Subject: Re: sata_sis only recognizing primary drive in 2.6.18
Date: Mon, 23 Oct 2006 11:14:57 +0900 [thread overview]
Message-ID: <453C25A1.5010208@gmail.com> (raw)
In-Reply-To: <453A8B66.8080302@gmx.net>
Uwe Koziolek wrote:
> Hi,
>
> I have tested the patch with separate port_info and a patch only adding
> the flag ATA_FLAG_SLAVE_POSS for all controllers.
> The result is allways the same. The second sata disk is allways
> /dev/sdb. libata handles this correctly.
>
> So i am not sure, that the separate port_info is really necessary. My
> assumption is a ATA_FLAG_SLAVE_POSS
> is sufficient for a correct handling.
>
> If i am wrong, i will send a patch with separate port_info .
It might be sufficient to just add ATA_FLAG_SLAVE_POSS for all
controllers but in general we don't want to sprinkle that flag over
controllers which don't actually support slave device - sometimes for
safety and also for documentation purpose. So, please make a separate
port_info and add ATA_FLAG_SLAVE_POSS only to controllers which actually
support slave devices.
Thanks.
--
tejun
next prev parent reply other threads:[~2006-10-23 2:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 6:58 sata_sis only recognizing primary drive in 2.6.18 Jim Paris
2006-10-06 10:57 ` Uwe Koziolek
2006-10-06 21:22 ` Jim Paris
2006-10-08 4:24 ` Tejun Heo
2006-10-21 21:04 ` Uwe Koziolek
2006-10-23 2:14 ` Tejun Heo [this message]
2006-10-23 8:45 ` Uwe Koziolek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453C25A1.5010208@gmail.com \
--to=htejun@gmail.com \
--cc=fragmede@gmail.com \
--cc=jim@jtan.com \
--cc=linux-ide@vger.kernel.org \
--cc=muthas@mit.edu \
--cc=touch@sis.com \
--cc=uwe.koziolek@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.