All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <esandeen@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] more helpful WARN_ON and BUG_ON messages
Date: Sun, 22 Oct 2006 22:18:32 -0500	[thread overview]
Message-ID: <453C3488.2050401@redhat.com> (raw)
In-Reply-To: <45393CBD.8000400@goop.org>

Jeremy Fitzhardinge wrote:

> This seems like a generally useful idea - certainly more valuable than 
> storing+printing the function name.
> 
> You might want to look at the BUG patches I wrote, which are currently 
> in -mm.  I added general machinery to allow architectures to easily 
> implement BUG() efficiently (ie, with a minimal amount of BUG-related 
> icache pollution).  If you were to store the BUG_ON expression, it would 
> be best to extend struct bug_entry and store it there - doing it in 
> asm-generic BUG_ON() means you still end up with code to set up the 
> printk in the mainline code path, and it also won't honour 
> CONFIG_DEBUG_BUGVERBOSE being disabled.

Thanks, I missed that change... I'll look into it.

-Eric

  reply	other threads:[~2006-10-23  3:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-20 16:23 [PATCH] more helpful WARN_ON and BUG_ON messages Eric Sandeen
2006-10-20 16:54 ` [PATCH] (update) " Eric Sandeen
2006-10-20 17:02   ` Peter Zijlstra
2006-10-20 19:30   ` Eric Sandeen
2006-10-20 21:16 ` [PATCH] " Jeremy Fitzhardinge
2006-10-23  3:18   ` Eric Sandeen [this message]
2006-10-20 21:41 ` Adrian Bunk
2006-10-20 21:56   ` Eric Sandeen
2006-10-20 22:07     ` Adrian Bunk
2006-10-21  2:41       ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453C3488.2050401@redhat.com \
    --to=esandeen@redhat.com \
    --cc=akpm@osdl.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.