All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Trimarchi <michael@evidence.eu.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] ixdp 465
Date: Mon, 23 Oct 2006 09:58:33 +0200	[thread overview]
Message-ID: <453C7629.4050701@evidence.eu.com> (raw)
In-Reply-To: <20061020073224.026E9353CB4@atlas.denx.de>

Hi,
Wolfgang Denk wrote:

>Such a plain diff output is not a patch, it cannot be applied. Please
>make sure to read the README, section Submitting  Patches.  You  MUST
>use the correct options when creating the patch.
>
Ok, some people ask me for a patch because they need it. I will produce 
a better patch.

>
>Also mind the size limitations on the mailing list.
>
>And make sure to stick  to  the  required  coding  style,  your  code
>contains lots of problems (indentation by spaces instead of TABs, C++
>comments, trailing white space, etc.).
>
thank's,
I'm going to fix

>
>Also never add change log entires to any files. We use git for this
>purpose.
>
Ok

>
>Make sure your code does not contain dead code (#if 0 etc.).
>
The dead code is already present,  I just add my code, without dead 
code. Thank's a lot for your comment

>
>
>
>Please cleanup and resubmit.
>
>Best regards,
>
>Wolfgang Denk
>  
>
Regards Michael

  reply	other threads:[~2006-10-23  7:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <453877C8.10103@evidence.eu.com>
2006-10-20  7:32 ` [U-Boot-Users] ixdp 465 Wolfgang Denk
2006-10-23  7:58   ` Michael Trimarchi [this message]
2006-10-10 17:04 Michael Trimarchi
2006-10-10 18:31 ` Stefan Roese
2006-10-11  6:59   ` Michael Trimarchi
     [not found]   ` <4537C382.1080300@evidence.eu.com>
2006-10-20  5:00     ` Stefan Roese
2006-10-20  6:59       ` Michael Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453C7629.4050701@evidence.eu.com \
    --to=michael@evidence.eu.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.