From: Anthony Liguori <aliguori@us.ibm.com>
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: Re: Error reporting capabilities for libxc
Date: Mon, 23 Oct 2006 16:14:59 -0500 [thread overview]
Message-ID: <453D30D3.6090007@us.ibm.com> (raw)
In-Reply-To: <3AAA99889D105740BE010EB6D5A5A3B205073C@paddington.ad.cl.cam.ac.uk>
Ian Pratt wrote:
> Would we be better off returning an error code and a set of parameters,
> requiring a call-back into the library to get the string?
>
> It's worth thinking about future language localisation here too.
>
I know it's a bigger patch, but the Right Thing to do here is to just
propagate an error code through the libxc functions.
The whole xc_{get,set}_error() is a cludge. Threading wouldn't be a
problem if we returned proper error codes.
Looking at your patch, it doesn't seem like it would really be that hard...
Regards,
Anthony Liguori
> Ian
>
next prev parent reply other threads:[~2006-10-23 21:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 12:58 Error reporting capabilities for libxc Ian Pratt
2006-09-26 13:20 ` Daniel P. Berrange
2006-10-23 18:00 ` Daniel P. Berrange
2006-10-23 19:17 ` Anthony Liguori
2006-10-23 19:27 ` Daniel P. Berrange
2006-10-23 20:04 ` Anthony Liguori
2006-10-23 20:08 ` Daniel P. Berrange
2006-10-23 20:54 ` Ian Pratt
2006-10-23 20:57 ` Daniel P. Berrange
2006-10-23 21:10 ` Ian Pratt
2006-10-23 21:14 ` Anthony Liguori [this message]
2006-10-23 21:28 ` Daniel P. Berrange
2006-10-23 21:38 ` Anthony Liguori
2006-10-23 21:47 ` John Levon
2006-10-24 9:15 ` Daniel Veillard
2006-10-23 21:48 ` Daniel P. Berrange
2006-10-24 7:47 ` Gerd Hoffmann
2006-10-24 9:07 ` Keir Fraser
2006-10-24 10:26 ` Gerd Hoffmann
2006-10-23 21:21 ` Daniel P. Berrange
2006-10-23 22:15 ` Ian Pratt
2006-10-23 23:05 ` Daniel P. Berrange
2006-10-23 20:40 ` John Levon
2006-10-23 21:04 ` John Levon
2006-10-23 21:09 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453D30D3.6090007@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=berrange@redhat.com \
--cc=m+Ian.Pratt@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.