From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: Re: Error reporting capabilities for libxc
Date: Mon, 23 Oct 2006 16:14:59 -0500
Message-ID: <453D30D3.6090007@us.ibm.com>
References: <453D1554.8000202@us.ibm.com> <20061023192753.GG25795@redhat.com>
	<3AAA99889D105740BE010EB6D5A5A3B205073B@paddington.ad.cl.cam.ac.uk>
	<20061023205730.GI25795@redhat.com>
	<3AAA99889D105740BE010EB6D5A5A3B205073C@paddington.ad.cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <3AAA99889D105740BE010EB6D5A5A3B205073C@paddington.ad.cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com, "Daniel P. Berrange" <berrange@redhat.com>
List-Id: xen-devel@lists.xenproject.org

Ian Pratt wrote:
> Would we be better off returning an error code and a set of parameters,
> requiring a call-back into the library to get the string? 
>
> It's worth thinking about future language localisation here too.
>   

I know it's a bigger patch, but the Right Thing to do here is to just 
propagate an error code through the libxc functions.

The whole xc_{get,set}_error() is a cludge.  Threading wouldn't be a 
problem if we returned proper error codes.

Looking at your patch, it doesn't seem like it would really be that hard...

Regards,

Anthony Liguori

> Ian 
>