From: Shailendra Tripathi <stripathi@agami.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs@oss.sgi.com, t-nagano@ah.jp.nec.com, xfs-dev@sgi.com
Subject: Re: [REVIEW 3 of 4] Fix recalim handling in xfs_iget_core
Date: Tue, 24 Oct 2006 11:23:11 -0700 [thread overview]
Message-ID: <453E5A0F.4070902@agami.com> (raw)
In-Reply-To: <20061024072054.GT11034@melbourne.sgi.com>
Hi David,
I can't really see why we need this test:
if (xfs_iflags_test(ip, XFS_IRECLAIMABLE))
I think, An inode with no VP can be possibly in only 3
states (NEW, RECLAIM or RECLAIMABLE). This check is being made inside
(inode_vp == NULL) check. If I am correct, may be we can omit an extra
instruction here.
It appears that you can see inode with XFS_ISTALE can
potentially reach. I am not sure how it should reach that path.
Following code just after this assumes that it must be in reclaimable path:
XFS_MOUNT_ILOCK(mp);
list_del_init(&ip->i_reclaim);
XFS_MOUNT_IUNLOCK(mp);
Regards,
Shailendra
David Chinner wrote:
next prev parent reply other threads:[~2006-10-24 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 7:20 [REVIEW 3 of 4] Fix recalim handling in xfs_iget_core David Chinner
2006-10-24 18:23 ` Shailendra Tripathi [this message]
2006-10-26 9:58 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453E5A0F.4070902@agami.com \
--to=stripathi@agami.com \
--cc=dgc@sgi.com \
--cc=t-nagano@ah.jp.nec.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.