All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <alexey_y_starikovskiy@linux.intel.com>
To: Linux ACPI <linux-acpi@vger.kernel.org>,
	"Brown, Len" <len.brown@intel.com>,
	Borislav Deianov <borislav@users.sf.net>
Subject: [PATCH] make ibm_acpi work right with notify handlers.
Date: Wed, 25 Oct 2006 18:29:04 +0400	[thread overview]
Message-ID: <453F74B0.8080105@linux.intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hi,

There is a bug in ibm_acpi module, which prevents its clean removal.
This patch fixes the problem by moving setting notify_installed to the right place.

Thanks,
Alex.

[-- Attachment #2: ibm_acpi-do_notify_remove.patch --]
[-- Type: text/x-patch, Size: 675 bytes --]

make unload of ibm_acpi right.

From:  Alexey Starikovskiy <alexey.y.starikovskiy@intel.com>


---

 drivers/acpi/ibm_acpi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 003a987..719a320 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
@@ -1805,7 +1805,7 @@ static int __init setup_notify(struct ib
 		       ibm->name, status);
 		return -ENODEV;
 	}
-
+	ibm->notify_installed = 1;
 	return 0;
 }
 
@@ -1882,7 +1882,6 @@ static int __init ibm_init(struct ibm_st
 		ret = setup_notify(ibm);
 		if (ret < 0)
 			return ret;
-		ibm->notify_installed = 1;
 	}
 
 	return 0;

             reply	other threads:[~2006-10-25 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-25 14:29 Alexey Starikovskiy [this message]
2006-10-27  5:34 ` [PATCH] make ibm_acpi work right with notify handlers Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453F74B0.8080105@linux.intel.com \
    --to=alexey_y_starikovskiy@linux.intel.com \
    --cc=borislav@users.sf.net \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.